Allow to disable b-frames for video codec (#284)

Author: YomesInc

js/jquery.cloudinary.js

@@ -1093,11 +1093,11 @@ var slice = [].slice,
     *
     * If the parameter is an object,
     * @param {(string|Object)} param - the video codec as either a String or a Hash
-    * @return {string} the video codec string in the format codec:profile:level
+    * @return {string} the video codec string in the format codec:profile:level:b_frames
     * @example
-    * vc_[ :profile : [level]]
+    * vc_[ :profile : [level : [b_frames]]]
     * or
-      { codec: 'h264', profile: 'basic', level: '3.1' }
+      { codec: 'h264', profile: 'basic', level: '3.1', b_frames: false }
     * @ignore
      */
 
@@ -1112,6 +1112,9 @@ var slice = [].slice,
               video += ":" + param['profile'];
               if ('level' in param) {
                 video += ":" + param['level'];
+                if ('b_frames' in param && param['b_frames'] === false) {
+                  video += ":bframes_no";
+                }
               }
             }
           }

samples/webpack/bundle.js

@@ -623,11 +623,11 @@
 	      *
 	      * If the parameter is an object,
 	      * @param {(string|Object)} param - the video codec as either a String or a Hash
-	      * @return {string} the video codec string in the format codec:profile:level
+	      * @return {string} the video codec string in the format codec:profile:level:b_frames
 	      * @example
-	      * vc_[ :profile : [level]]
+	      * vc_[ :profile : [level : [b_frames]]]
 	      * or
-	        { codec: 'h264', profile: 'basic', level: '3.1' }
+	        { codec: 'h264', profile: 'basic', level: '3.1', b_frames: false }
 	      * @ignore
 	       */
 
@@ -642,6 +642,9 @@
 	                video += ":" + param['profile'];
 	                if ('level' in param) {
 	                  video += ":" + param['level'];
+	                  if ('b_frames' in param && param.b_frames === false) {
+	                    video += ":bframes_no";
+	                  }
 	                }
 	              }
 	            }

src/parameters.js

@@ -103,11 +103,11 @@ class Param {
   *
   * If the parameter is an object,
   * @param {(string|Object)} param - the video codec as either a String or a Hash
-  * @return {string} the video codec string in the format codec:profile:level
+  * @return {string} the video codec string in the format codec:profile:level:b_frames
   * @example
-  * vc_[ :profile : [level]]
+  * vc_[ :profile : [level : [b_frames]]]
   * or
-    { codec: 'h264', profile: 'basic', level: '3.1' }
+    { codec: 'h264', profile: 'basic', level: '3.1', b_frames: false }
   * @ignore
    */
   static process_video_params(param) {
@@ -121,6 +121,9 @@ class Param {
             video += ":" + param.profile;
             if ('level' in param) {
               video += ":" + param.level;
+              if ('b_frames' in param && param.b_frames === false) {
+                video += ":bframes_no";
+              }
             }
           }
         }

test/spec/automatic/videourlspec.js

@@ -16,7 +16,7 @@ jasmine.getEnv().addReporter(new SpecReporter({
 // List of files to test
 const files = [
   {name: 'canvas-to-blob.min.js', checkSum: "7c7becb6f9ecf2defa663e70a6b3a0f5"},
-  {name: 'jquery.cloudinary.js', checkSum: "388dffde6d46b70fae4f0dfc254f48c5"},
+  {name: 'jquery.cloudinary.js', checkSum: "22e7276c8dec1760246a230fd9fa26c3"},
   {name: 'jquery.fileupload.js', checkSum: "4bfd85460689a29e314ddfad50c184e0"},
   {name: 'jquery.fileupload-image.js', checkSum: "7c40367b00f74b0c7c43bff009dde942"},
   {name: 'jquery.fileupload-process.js', checkSum: "840f65232eaf1619ea0aff1ab4f5e444"},

test/spec/env/js-folder-spec.js

@@ -183,7 +183,7 @@ cld.videoTag("movie").setSourceTypes('mp4')
     .transformation()
     .htmlHeight("100")
     .htmlWidth("200")
-    .videoCodec({ codec: 'h264', profile: 'basic', level: '3.1' })
+    .videoCodec({ codec: 'h264', profile: 'basic', level: '3.1', b_frames: false })
     .audioCodec("aac")
     .startOffset(3)
     .toHtml();

types/cloudinary-core-tests.ts

@@ -239,7 +239,7 @@ export class Transformation {
     underlay(value: string): Transformation; // public id of an uploaded image
     variable(name: string, value: any): Transformation;
     variables(value: Array<[string, any]>): Transformation;
-    videoCodec(value: string | Object): Transformation; // Select the video codec and control the video content of the profile used. Can be provided in the form <codec>[:<profile>:[<level>]] to specify specific values to apply for video codec, profile and level, e.g. "h264:baseline:3.1". Also accepts a hash of values such as { codec: 'h264', profile: 'basic', level: '3.1' }
+    videoCodec(value: string | Object): Transformation; // Select the video codec and control the video content of the profile used. Can be provided in the form <codec>[:<profile>:[<level>:[<:b_frames>]]] to specify specific values to apply for video codec, profile, level and b_frames, e.g. "h264:baseline:3.1:bframes_no". Also accepts a hash of values such as { codec: 'h264', profile: 'basic', level: '3.1', b_frames: false }
     videoSampling(value: number | string): Transformation; // Integer - The total number of frames to sample from the original video. String - The number of seconds between each frame to sample from the original video. e.g. 2.3s takes one frame every 2.3 seconds.
     width(value: string | number): Transformation; // Number of pixels, width % or "auto" with rounding step
     x(value: number): Transformation; // pixels or percent
@@ -373,7 +373,7 @@ export namespace Transformation {
         sourceTransformation?: string;
         startOffset?: number | string; // Float or string
         streamingProfile?: StreamingProfiles
-        videoCodec?: string | Object; // Select the video codec and control the video content of the profile used. Can be provided in the form <codec>[:<profile>:[<level>]] to specify specific values to apply for video codec, profile and level, e.g. "h264:baseline:3.1". Also accepts a hash of values such as { codec: 'h264', profile: 'basic', level: '3.1' }
+        videoCodec?: string | Object; // Select the video codec and control the video content of the profile used. Can be provided in the form <codec>[:<profile>:[<level>:[<:b_frames>]]] to specify specific values to apply for video codec, profile, level and b_frames, e.g. "h264:baseline:3.1:bframes_no". Also accepts a hash of values such as { codec: 'h264', profile: 'basic', level: '3.1', b_frames: false }
         videoSampling?: number | string; // Integer - The total number of frames to sample from the original video. The frames are spread out over the length of the video, e.g. 20 takes one frame every 5% -- OR -- String - The number of seconds between each frame to sample from the original video. e.g. 2.3s takes one frame every 2.3 seconds.
     }
 }