-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Ensure that wrangler dev and vite dev/preview crash when we fail to create a remote proxy session
#11383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that wrangler dev and vite dev/preview crash when we fail to create a remote proxy session
#11383
Conversation
🦋 Changeset detectedLatest commit: 8767488 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
01af02d to
3150fcc
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
3150fcc to
ece6d21
Compare
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor comments
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
0cf1c84 to
0af9d63
Compare
297f94e to
b7ab666
Compare
b7ab666 to
e0b7e93
Compare
| `${errorSpy.mock.calls?.[0]?.[0]}` | ||
| // Windows gets a different marker for ✘, so let's normalize it here | ||
| // so that this test can be platform independent | ||
| .replaceAll("✘", "X") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it would be good to have a common helper for that - could be addressed in a follow up PR
…nnot be established an appropriate error is surfaced to the user
Co-authored-by: Victor Berchet <[email protected]>
Co-authored-by: Victor Berchet <[email protected]>
4143b2a to
8767488
Compare
Fixes #11253
This PR makes sure that both wrangler and the vite-plugin appropriately error when a remote proxy session fails to be established (instead of making requests hang for example).