Various workers-utils improvements/fixes (#11460)

* Add missing `test` script in workers-utils package

* Move parse tests from wrangler to workers-utils (since they are testing workers-utils functions)

* add `vitest/globals` to workers-utils tests tsconfig

* add missing `type:tests` script to workers-utils

Author: dario-piotrowicz

packages/workers-utils/package.json

@@ -32,7 +32,9 @@
 		"check:lint": "eslint . --max-warnings=0",
 		"check:type": "tsc -p ./tsconfig.json",
 		"dev": "concurrently -c black,blue --kill-others-on-fail false \"pnpm tsup --watch src\" \"pnpm run check:type --watch --preserveWatchOutput\"",
-		"test:ci": "vitest run"
+		"test": "vitest",
+		"test:ci": "vitest run",
+		"type:tests": "tsc -p ./tests/tsconfig.json"
 	},
 	"devDependencies": {
 		"@cloudflare/containers-shared": "workspace:*",

packages/wrangler/src/__tests__/parse.test.ts renamed to packages/workers-utils/tests/parse.test.ts

@@ -5,85 +5,7 @@ import {
 	parseJSONC,
 	parseTOML,
 	searchLocation,
-} from "@cloudflare/workers-utils";
-import { formatMessage } from "../utils/format-message";
-import type { Message } from "@cloudflare/workers-utils";
-
-describe("formatMessage", () => {
-	const format = (input: Message) => {
-		// No color and skip emojis at the start.
-		return formatMessage(input, false).substring(2);
-	};
-
-	it("should format message without location", () => {
-		expect(
-			format({
-				text: "Invalid argument",
-				kind: "warning",
-			})
-		).toMatchInlineSnapshot(`
-      "[WARNING] Invalid argument
-
-      "
-    `);
-	});
-
-	it("should format message with location", () => {
-		expect(
-			format({
-				text: "Missing property: main",
-				location: {
-					line: 1,
-					column: 0,
-					lineText: "{}",
-					file: "package.json",
-					fileText: "{}",
-				},
-			})
-		).toMatchInlineSnapshot(`
-      "[ERROR] Missing property: main
-
-          package.json:1:0:
-            1 │ {}
-              ╵ ^
-
-      "
-    `);
-	});
-
-	it("should format message with location and notes", () => {
-		expect(
-			format({
-				text: "Invalid property: type",
-				location: {
-					line: 3,
-					column: 8,
-					length: 7,
-					lineText: "type = 'modular'",
-					suggestion: "Did you mean 'module'?",
-					file: "package.toml",
-					fileText: "[package]\ntype = 'modular'\n",
-				},
-				notes: [
-					{
-						text: "There are two acceptable types: 'module' and 'commonjs'",
-					},
-				],
-			})
-		).toMatchInlineSnapshot(`
-      "[ERROR] Invalid property: type
-
-          package.toml:3:8:
-            3 │ type = 'modular'
-              │         ~~~~~~~
-              ╵         Did you mean 'module'?
-
-        There are two acceptable types: 'module' and 'commonjs'
-
-      "
-    `);
-	});
-});
+} from "../src/parse";
 
 describe("parseTOML", () => {
 	it("should parse toml that is empty", () => {

packages/workers-utils/tests/tsconfig.json

@@ -2,7 +2,7 @@
 	"extends": "@cloudflare/workers-tsconfig/tsconfig.json",
 	"compilerOptions": {
 		"module": "preserve",
-		"types": ["node"],
+		"types": ["node", "vitest/globals"],
 		"jsx": "preserve"
 	},
 	"include": ["../*.d.ts", "**/*.ts", "**/*.tsx", "**/*.js"]

packages/wrangler/src/__tests__/utils/format-message.test.ts

@@ -0,0 +1,78 @@
+import { formatMessage } from "../../utils/format-message";
+import type { Message } from "@cloudflare/workers-utils";
+
+describe("formatMessage", () => {
+	const format = (input: Message) => {
+		// No color and skip emojis at the start.
+		return formatMessage(input, false).substring(2);
+	};
+
+	it("should format message without location", () => {
+		expect(
+			format({
+				text: "Invalid argument",
+				kind: "warning",
+			})
+		).toMatchInlineSnapshot(`
+      "[WARNING] Invalid argument
+
+      "
+    `);
+	});
+
+	it("should format message with location", () => {
+		expect(
+			format({
+				text: "Missing property: main",
+				location: {
+					line: 1,
+					column: 0,
+					lineText: "{}",
+					file: "package.json",
+					fileText: "{}",
+				},
+			})
+		).toMatchInlineSnapshot(`
+      "[ERROR] Missing property: main
+
+          package.json:1:0:
+            1 │ {}
+              ╵ ^
+
+      "
+    `);
+	});
+
+	it("should format message with location and notes", () => {
+		expect(
+			format({
+				text: "Invalid property: type",
+				location: {
+					line: 3,
+					column: 8,
+					length: 7,
+					lineText: "type = 'modular'",
+					suggestion: "Did you mean 'module'?",
+					file: "package.toml",
+					fileText: "[package]\ntype = 'modular'\n",
+				},
+				notes: [
+					{
+						text: "There are two acceptable types: 'module' and 'commonjs'",
+					},
+				],
+			})
+		).toMatchInlineSnapshot(`
+      "[ERROR] Invalid property: type
+
+          package.toml:3:8:
+            3 │ type = 'modular'
+              │         ~~~~~~~
+              ╵         Did you mean 'module'?
+
+        There are two acceptable types: 'module' and 'commonjs'
+
+      "
+    `);
+	});
+});