Skip to content

Commit 0cf1c84

Browse files
Apply suggestions from code review
Co-authored-by: Victor Berchet <[email protected]>
1 parent ece6d21 commit 0cf1c84

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/vite-plugin-cloudflare/e2e/remote-bindings.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ describe("failure to connect to remote bindings", () => {
173173
// we need to skip this on windows since in CI we're using node 20
174174
// we should look into re-enable this once we can move to a node a newer version of node
175175
test.skipIf(process.platform === "win32")(
176-
"cannot connect to remote bindings",
176+
"exit with a non zero error code and log an error",
177177
async ({ expect }) => {
178178
const proc = await runLongLived("pnpm", command, projectPath);
179179

packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ describe("errors during dev with remote bindings", () => {
2424
msw.use(...mswSuccessUserHandlers);
2525
});
2626

27-
it("errors triggered when creating the remote proxy session are appropriately surfaced", async () => {
27+
it("errors triggered when creating the remote proxy session are surfaced", async () => {
2828
let thrownError: Error | undefined;
2929

3030
try {
@@ -53,7 +53,7 @@ describe("errors during dev with remote bindings", () => {
5353
);
5454
});
5555

56-
it("errors triggered when establishing the remote proxy session (after it has been created) are appropriately surfaced", async () => {
56+
it("errors triggered when establishing the remote proxy session (after it has been created) are surfaced", async () => {
5757
vi.mocked(createPreviewSession).mockResolvedValue({
5858
id: "test-session-id",
5959
value: "test-session-value",

0 commit comments

Comments
 (0)