Merge pull request #4 from clouddrove/CD-118

fix bool

Author: anmolnagpal

README.md

@@ -7,7 +7,7 @@
     Terraform Aws Acm
 </h1>
 
-<p align="center" style="font-size: 1.2rem;">
+<p align="center" style="font-size: 1.2rem;"> 
     This terraform module is used for requesting or importing SSL/TLS certificate with validation.
      </p>
 
@@ -38,7 +38,7 @@
 <hr>
 
 
-We eat, drink, sleep and most importantly love **DevOps**. We are working towards stratergies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure.
+We eat, drink, sleep and most importantly love **DevOps**. We are working towards stratergies for standardizing architecture while ensuring security for the infrastructure. We are strong believer of the philosophy <b>Bigger problems are always solved by breaking them into smaller manageable problems</b>. Resonating with microservices architecture, it is considered best-practice to run database, cluster, storage in smaller <b>connected yet manageable pieces</b> within the infrastructure. 
 
 This module is basically combination of [Terraform open source](https://www.terraform.io/) and includes automatation tests and examples. It also helps to create and improve your infrastructure with minimalistic code instead of maintaining the whole infrastructure code yourself.
 
@@ -49,7 +49,7 @@ We have [*fifty plus terraform modules*][terraform_modules]. A few of them are c
 
 ## Prerequisites
 
-This module has a few dependencies:
+This module has a few dependencies: 
 
 - [Terraform 0.12](https://learn.hashicorp.com/terraform/getting-started/install.html)
 - [Go](https://golang.org/doc/install)
@@ -61,8 +61,10 @@ This module has a few dependencies:
 
 
 
+
 ## Examples
 
+
 **IMPORTANT:** Since the `master` branch used in `source` varies based on new modifications, we suggest that you use the release versions [here](https://github.com/clouddrove/terraform-aws-acm/releases).
 
 
@@ -74,28 +76,26 @@ module "acm" {
   name                     = "certificate"
   application              = "clouddrove"
   environment              = "test"
-  label_order              = ["environment", "application", "name"]
+  label_order              = ["environment", "name", "application"]
   domain_name              = "clouddrove.com"
   validation_method        = "DNS"
   enable_dns_validation    = false
   enable_aws_certificate   = true
-
 }
 ```
 
 ### ACM with Email
 ```hcl
 module "acm" {
-  source                 = "git::https://github.com/clouddrove/terraform-aws-acm.git?ref=tags/0.12.1"
-  name                   = "certificate"
-  application            = "clouddrove"
-  environment            = "test"
-  label_order            = ["environment", "application", "name"]
-  domain_name            = "clouddrove.com"
-  validation_method      = "EMAIL"
-  validate_certificate   = false
+  source                = "git::https://github.com/clouddrove/terraform-aws-acm.git?ref=tags/0.12.1"
+  name                  = "certificate"
+  application           = "clouddrove"
+  environment           = "test"
+  label_order           = ["environment", "name", "application"]
+  domain_name           = "clouddrove.com"
+  validation_method     = "EMAIL"
+  validate_certificate  = false
   enable_aws_certificate = true
-
 }
 ```
 
@@ -106,7 +106,7 @@ module "acm" {
   name                = "certificate"
   application         = "clouddrove"
   environment         = "test"
-  label_order         = ["environment", "application", "name"]
+  label_order         = ["environment", "name", "application"]
   private_key         = "./../../../clouddrove-private-key.pem"
   certificate_body    = "./../../../clouddrove-cert.pem"
   certificate_chain   = "./../../../clouddrove-chain.crt"
@@ -116,6 +116,9 @@ module "acm" {
 
 
 
+
+
+
 ## Inputs
 
 | Name | Description | Type | Default | Required |
@@ -127,6 +130,7 @@ module "acm" {
 | delimiter | Delimiter to be used between `organization`, `environment`, `name` and `attributes`. | string | `-` | no |
 | domain_name | A domain name for which the certificate should be issued. | string | - | yes |
 | enable_acm_certificate | Set to false to prevent the creation of a acm certificate. | string | `true` | no |
+| enable_aws_certificate | Set to false to prevent the creation of a acm certificate. | bool | `false` | no |
 | enable_dns_validation | Set to prevent validation of DNS. | string | `false` | no |
 | environment | Environment (e.g. `prod`, `dev`, `staging`). | string | `` | no |
 | import_certificate | Set to true or false to decide the creation and import of a acm certificate. | bool | `false` | no |
@@ -143,15 +147,14 @@ module "acm" {
 | Name | Description |
 |------|-------------|
 | arn | The ARN of the Certificate. |
-| domain_validation_options | The domain validation option of the Certificate. |
 | id | The ID of the Certificate. |
 | tags | A mapping of tags to assign to the resource. |
 
 
 
-## Testing
 
-In this module testing is performed with [terratest](https://github.com/gruntwork-io/terratest) and it creates a small piece of infrastructure, matches the output like ARN, ID and Tags name etc and destroy infrastructure in your AWS account. This testing is written in GO, so you need a [GO environment](https://golang.org/doc/install) in your system.
+## Testing
+In this module testing is performed with [terratest](https://github.com/gruntwork-io/terratest) and it creates a small piece of infrastructure, matches the output like ARN, ID and Tags name etc and destroy infrastructure in your AWS account. This testing is written in GO, so you need a [GO environment](https://golang.org/doc/install) in your system. 
 
 You need to run the following command in the testing folder:
 ```hcl
@@ -160,7 +163,7 @@ You need to run the following command in the testing folder:
 
 
 
-## Feedback
+## Feedback 
 If you come accross a bug or have any feedback, please log it in our [issue tracker](https://github.com/clouddrove/terraform-aws-acm/issues), or feel free to drop us an email at [[email protected]](mailto:[email protected]).
 
 If you have found it worth your time, go ahead and give us a ★ on [our GitHub](https://github.com/clouddrove/terraform-aws-acm)!

README.yaml

@@ -52,7 +52,7 @@ usage : |-
   ```hcl
   module "acm" {
     source                = "git::https://github.com/clouddrove/terraform-aws-acm.git?ref=tags/0.12.1"
-    name                  = "certificate
+    name                  = "certificate"
     application           = "clouddrove"
     environment           = "test"
     label_order           = ["environment", "name", "application"]