new eslint version + fixes

Author: carlhoerberg

.eslintrc.json

@@ -0,0 +1,19 @@
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+import globals from "globals";
+
+export default tseslint.config(
+  {
+    ignores: ["**/types/", "**/dist/", "**/lib/"]
+  },
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  {
+    files: ["examples/*.js"],
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
+  }
+);

eslint.config.mjs

@@ -59,11 +59,10 @@
   "homepage": "https://github.com/cloudamqp/amqp-client.js#readme",
   "devDependencies": {
     "@types/node": "*",
-    "@typescript-eslint/eslint-plugin": "*",
-    "@typescript-eslint/parser": "*",
     "@vitest/browser": "*",
     "@vitest/coverage-v8": "*",
     "eslint": "*",
+    "typescript-eslint": "*",
     "playwright": "*",
     "rollup": "*",
     "rollup-plugin-sourcemaps": "*",

package.json

@@ -163,13 +163,14 @@ export abstract class AMQPBaseClient {
       const type = view.getUint8(i); i += 1
       const channelId = view.getUint16(i); i += 2
       const frameSize = view.getUint32(i); i += 4
+      let frameEnd = 0
       try {
-        const frameEnd = view.getUint8(i + frameSize)
-        if (frameEnd !== 206)
-          throw (new AMQPError(`Invalid frame end ${frameEnd}, expected 206`, this))
-      } catch (e) {
+        frameEnd = view.getUint8(i + frameSize)
+      } catch {
         throw (new AMQPError(`Frame end out of range, frameSize=${frameSize}, pos=${i}, byteLength=${view.byteLength}`, this))
       }
+      if (frameEnd !== 206)
+        throw (new AMQPError(`Invalid frame end ${frameEnd}, expected 206`, this))
 
       const channel = this.channels[channelId]
       if (!channel) {

src/amqp-base-client.ts

@@ -831,13 +831,13 @@ export class AMQPChannel {
    * Resolvs next RPC command
    * @ignore
    */
-  resolveRPC(value?: unknown) : void { value }
+  resolveRPC(value?: unknown) : unknown | void { return value }
 
   /**
    * Reject next RPC command
    * @ignore
    */
-  rejectRPC(err?: Error) : void { err }
+  rejectRPC(err?: Error) : Error | void { return err }
 
   /**
    * Deliver a message to a consumer

src/amqp-channel.ts

@@ -16,7 +16,6 @@ export class AMQPView extends DataView<Uint8Array['buffer']>  {
     const combined = littleEndian ? left + 2**32 * right : 2**32 * left + right
 
     if (!Number.isSafeInteger(combined)) {
-      // eslint-disable-next-line no-console
       console.warn(combined, 'exceeds MAX_SAFE_INTEGER. Precision may be lost')
     }