CLJS-2803: Remove :record-value op and add record literal tests

Author: frenchy64

src/main/clojure/cljs/analyzer.cljc

@@ -3572,23 +3572,24 @@
          :children [:items]
          :tag 'array}))))
 
+(defn record-ns+name [x]
+  (map symbol
+       #?(:clj
+          ((juxt (comp #(string/join "." %) butlast) last)
+           (string/split (.getName ^Class (type x)) #"\."))
+          :cljs
+          (string/split (pr-str (type x)) #"/"))))
+
 (defn analyze-record
   [env x]
-  (let [items     (disallowing-recur
+  (let [;; register constansts
+        _items_   (disallowing-recur
                     (analyze (assoc env :context :expr) (into {} x)))
-        [ns name] (map symbol
-                    #?(:clj
-                       ((juxt (comp #(string/join "." %) butlast) last)
-                         (string/split (.getName ^Class (type x)) #"\."))
-                       :cljs
-                       (string/split (pr-str (type x)) #"/")))]
-    {:op :record-value
-     :ns ns
-     :name name
+        [ns name] (record-ns+name x)]
+    {:op :const
+     :val x
      :env env
      :form x
-     :items items
-     :children [:items]
      :tag (symbol (str ns) (str name))}))
 
 (defn elide-reader-meta [m]

src/main/clojure/cljs/compiler.cljc

@@ -233,7 +233,7 @@
    (defmulti emit-constant* type))
 
 (declare emit-map emit-list emit-vector emit-set emit-js-object emit-js-array
-         emit-with-meta emit-constants-comma-sep emit-constant)
+         emit-with-meta emit-constants-comma-sep emit-constant emit-record-value)
 
 (defn all-distinct? [xs]
   (apply distinct? xs))
@@ -242,6 +242,8 @@
    (defn emit-constant-no-meta [x]
      (cond
        (seq? x) (emit-list x emit-constants-comma-sep)
+       (record? x) (let [[ns name] (ana/record-ns+name x)]
+                     (emit-record-value ns name #(emit-constant (into {} x))))
        (map? x) (emit-map (keys x) (vals x) emit-constants-comma-sep all-distinct?)
        (vector? x) (emit-vector x emit-constants-comma-sep)
        (set? x) (emit-set x emit-constants-comma-sep all-distinct?)
@@ -250,6 +252,8 @@
    (defn emit-constant-no-meta [x]
      (cond
        (ana/cljs-seq? x) (emit-list x emit-constants-comma-sep)
+       (record? x) (let [[ns name] (ana/record-ns+name x)]
+                     (emit-record-value ns name #(emit-constant (into {} x))))
        (ana/cljs-map? x) (emit-map (keys x) (vals x) emit-constants-comma-sep all-distinct?)
        (ana/cljs-vector? x) (emit-vector x emit-constants-comma-sep)
        (ana/cljs-set? x) (emit-set x emit-constants-comma-sep all-distinct?)
@@ -554,10 +558,9 @@
   (emit-wrap env
     (emit-js-array items comma-sep)))
 
-(defmethod emit* :record-value
-  [{:keys [items ns name items env]}]
-  (emit-wrap env
-    (emits ns ".map__GT_" name "(" items ")")))
+(defn emit-record-value
+  [ns name items]
+  (emits ns ".map__GT_" name "(" items ")"))
 
 (defmethod emit* :quote
   [{:keys [expr]}]

src/test/cljs/data_readers_test/records.cljc

@@ -3,4 +3,24 @@
 
 (defrecord Foo [a b])
 
-(assert (= (Foo. 1 2) #data_readers_test.records.Foo{:a 1 :b 2}))
+(assert (= (Foo. 1 2) #data_readers_test.records.Foo{:a 1 :b 2}))
+(assert (= (Foo. 1 2)
+           '#data_readers_test.records.Foo{:a 1 :b 2}))
+(assert (= (Foo. 1 2)
+           (second ''#data_readers_test.records.Foo{:a 1 :b 2})))
+(assert (= (Foo. 'a 'b)
+           (let [a 1
+                 b 2]
+             #data_readers_test.records.Foo{:a a :b b}))
+        (pr-str
+          (let [a 1
+                b 2]
+            #data_readers_test.records.Foo{:a a :b b})))
+(assert (= (Foo. 'a 'b)
+           (let [a 1
+                 b 2]
+             '#data_readers_test.records.Foo{:a a :b b}))
+        (pr-str
+          (let [a 1
+                b 2]
+            '#data_readers_test.records.Foo{:a a :b b})))