Skip to content

support for outshine mode #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jave opened this issue Apr 15, 2025 · 3 comments
Open

support for outshine mode #82

jave opened this issue Apr 15, 2025 · 3 comments
Labels
feature request Request for new functionality good first issue Good for newcomers

Comments

@jave
Copy link

jave commented Apr 15, 2025

I like using outshine mode in clojure-mode buffers, but folding doesnt appear to work in clojure-ts mode.

https://github.com/alphapapa/outshine

@bbatsov bbatsov added the feature request Request for new functionality label Apr 15, 2025
@bbatsov
Copy link
Member

bbatsov commented Apr 17, 2025

Seems that's some extension of the built-in outline-mode. Probably we haven't implemented properly the support for outline, as I doubt outshine requires something special. Should be an easy task.

@bbatsov bbatsov added the good first issue Good for newcomers label Apr 17, 2025
@rrudakov
Copy link
Contributor

FYI, we need to define proper value for treesit-outline-predicate. From the documentation:

treesit-outline-predicate is a variable defined in ‘treesit.el’.

Its value is ‘treesit-outline-predicate--from-imenu’

Predicate used to find outline headings in the syntax tree.
The predicate can be a function, a regexp matching node type,
and more; see docstring of ‘treesit-thing-settings’.
It matches the nodes located on lines with outline headings.
Intended to be set by a major mode.  When nil, the predicate
is constructed from the value of ‘treesit-simple-imenu-settings’
when a major mode sets it.

@bbatsov
Copy link
Member

bbatsov commented Apr 17, 2025

Yeah, that's what I figured as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new functionality good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants