ddfc99b6 breaks cider--handle-stacktrace-response

[aiba]

Expected behavior

Exceptions thrown from cider-eval pop up an error buffer when an exception is thrown.

Actual behavior

An error buffer is not popped up, and the following gets printed to *Messages*:

error in process filter: Selecting deleted buffer

I tried to poke around the code and I think I narrowed it down to cider--handle-stacktrace-response. When this function gets called, source-buffer is bound to #<killed buffer>. I'm not sure how this buffer is getting killed but I don't recall killing it.

Reverting ddfc99b6 seems to fix it for me.

Steps to reproduce the problem

evaluate: (throw (ex-info "hello" {}))

Environment & Version information

CIDER 1.19.0-snapshot (package: 1.19.0-snapshot)
GNU Emacs 30.1 (build 2, aarch64-apple-darwin24.3.0, NS appkit-2575.40 Version 15.3.1 (Build 24D70)) of 2025-02-26
Clojure 1.12.0
java version "24" 2025-03-18
Java(TM) SE Runtime Environment (build 24+36-3646)
MacOS 15.5 arm64

[alexander-yakushev]

Hi! Would it be possible for you to test this on a bare setup where only CIDER is installed and nothing else? (no custom config)

[alexander-yakushev]

@aiba Do you still have this issue?

[aiba]

Yes, thank you for asking, and I'm now seeing the previous request for trying on a bare CIDER setup. I will try to narrow it down.

For what it's worth, it only happens on cider-pprint-eval-last-sexp, but not on cider-eval-last-sexp. With cier-eval-last-sexp, it pops up the error buffer with exception info. But with cider-pprint-eval-last-sexp, it does not. I mention this in case it gives you any ideas for how I can try to help debug this.

[aiba]

@alexander-yakushev yes, I'm getting the same behavior, even with bare setup. Here are my versions and the entirety of init.el:

GNU Emacs 30.1 (build 2, aarch64-apple-darwin24.3.0, NS appkit-2575.40 Version 15.3.1 (Build 24D70)) of 2025-02-25
CIDER 1.20.0-snapshot (package: 1.20.0-snapshot)

init.el:

(setq straight-recipes-emacsmirror-use-mirror t
      straight-recipes-gnu-elpa-use-mirror    t)

(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name
        "straight/repos/straight.el/bootstrap.el"
        (or (bound-and-true-p straight-base-dir)
            user-emacs-directory)))
      (bootstrap-version 7))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

(straight-use-package 'use-package)
(setq straight-use-package-by-default t)

(use-package clojure-mode)
(use-package cider)

[aiba]

After much debugging and trial-and-error, #3833 fixes this problem for me. Hopefully someone who understands the code better can validate whether this is the best way to fix it.

[aiba]

The fix works great, thank you!!!