Remove pretty mode and use a config option

Author: r0man

CHANGELOG.md

@@ -8,6 +8,7 @@
 
 * [#931](https://github.com/clojure-emacs/cider-nrepl/pull/931): Redesign and optimize track-state middleware.
 * [#932](https://github.com/clojure-emacs/cider-nrepl/pull/932) Add support for `:pretty` view-mode in inspector.
+* [#932](https://github.com/clojure-emacs/cider-nrepl/pull/932) Add support for pretty printing values in the inspector.
 
 ## 0.55.0 (2025-04-10)
 

src/cider/nrepl/middleware/inspect.clj

@@ -32,7 +32,8 @@
 
 (defn- msg->inspector-config [msg]
   (select-keys msg [:page-size :max-atom-length :max-coll-size
-                    :max-value-length :max-nested-depth :display-analytics-hint]))
+                    :max-value-length :max-nested-depth :display-analytics-hint
+                    :pretty-print]))
 
 (defn inspect-reply* [{:keys [view-mode] :as msg} value]
   (let [config (msg->inspector-config msg)
@@ -80,8 +81,8 @@
 (defn- toggle-view-mode [{:keys [view-mode] :as inspector}]
   ;; The order in which view modes are cycled depends on the inspected object.
   (let [toggle-order (if (inspect/supports-table-view-mode? inspector)
-                       {:normal :pretty, :pretty :table, :table :object, :object :normal}
-                       {:normal :pretty, :pretty :object, :object :normal})
+                       {:normal :table, :table :object, :object :normal}
+                       {:normal :object, :object :normal})
         next-view-mode (toggle-order view-mode :normal)]
     (inspect/set-view-mode inspector next-view-mode)))
 

test/clj/cider/nrepl/middleware/inspect_test.clj

@@ -653,8 +653,6 @@
          (value-skip-header (session/message {:op      "eval"
                                               :inspect "true"
                                               :code    "(list 1 2 3)"})))
-    (is+ (matchers/prefix pretty-mode-prefix)
-         (value-skip-header (session/message {:op "inspect-toggle-view-mode"})))
     (is+ (matchers/prefix object-mode-prefix)
          (value-skip-header (session/message {:op "inspect-toggle-view-mode"})))
     (is+ (matchers/prefix normal-mode-prefix)
@@ -665,8 +663,6 @@
     (session/message {:op      "eval"
                       :inspect "true"
                       :code    "(list 1 2 3)"})
-    (is+ (matchers/prefix pretty-mode-prefix)
-         (value-skip-header (session/message {:op "inspect-toggle-view-mode"})))
     (is+ (matchers/prefix object-mode-prefix)
          (value-skip-header (session/message {:op "inspect-toggle-view-mode"})))
     (is+ (matchers/prefix ["--- Contents:" [:newline]
@@ -699,12 +695,11 @@
     (session/message {:op      "eval"
                       :inspect "true"
                       :code    "(repeat 20 {:a 1})"})
-    (session/message {:op "inspect-toggle-view-mode"})
     (is+ (matchers/prefix table-mode-prefix)
          (value-skip-header (session/message {:op "inspect-toggle-view-mode"})))))
 
-(deftest pretty-view-mode-integration-test
-  (testing "pretty view-mode renders an object with a pretty printer"
+(deftest pretty-print-integration-test
+  (testing "renders an object with the pretty printer"
     (session/message {:op "inspect-clear"})
     (session/message {:op      "eval"
                       :inspect "true"
@@ -724,10 +719,9 @@
           [:newline]
           "  4. " [:value (str "{:a ({:b 2} {:b 2} {:b 2} {:b 2} {:b 2}),"
                                "\n      :c ({:d 2} {:d 2} {:d 2} {:d 2} {:d 2})}") 5]
-          [:newline] [:newline]
-          "--- View mode:" [:newline]
-          "  :pretty"]
-         (value-skip-header (session/message {:op "inspect-toggle-view-mode"})))))
+          [:newline]]
+         (value-skip-header (session/message {:op "inspect-refresh"
+                                              :pretty-print "true"})))))
 
 (deftest print-length-independence-test
   (testing "*print-length* doesn't break rendering of long collections"