Refactor bindings a bit + document it (#8)

* grandfathered docs improvements in bindings

* improve bindings

* address review comments

* remove late bound lifetime

* undo derive for Timestamp to bisect bug

Author: Centril

crates/bindings-macro/src/lib.rs

@@ -670,7 +670,7 @@ fn spacetimedb_tabletype_impl(item: syn::DeriveInput) -> syn::Result<TokenStream
         Some(quote! {
             // TODO: should we expose spacetimedb::query::FilterByIter ?
             #vis fn #filter_func_ident<'a>(#column_ident: &'a #column_type) -> impl Iterator<Item = Self> + 'a {
-                spacetimedb::query::filter_by_field::<'a, Self, #column_type, #column_index>(#column_ident)
+                spacetimedb::query::filter_by_field::<Self, #column_type, #column_index>(#column_ident)
             }
         })
     });

crates/bindings-sys/src/errno.rs

@@ -1,5 +1,10 @@
+/// Error code for "No such table".
 pub const NOTAB: u16 = 1;
+
+/// Error code for value/range not being found in a table.
 pub const LOOKUP: u16 = 2;
+
+/// Error code for when a unique constraint is violated.
 pub const EXISTS: u16 = 3;
 
 macro_rules! errnos {

crates/bindings-sys/src/lib.rs

@@ -452,7 +452,7 @@ pub fn create_index(index_name: &str, table_id: u32, index_type: u8, col_ids: &[
 
 /// Finds all rows in the table identified by `table_id`,
 /// where the row has a column, identified by `col_id`,
-/// with data matching `val.
+/// with data matching `val`.
 ///
 /// The rows found are bsatn encoded and then concatenated.
 /// The resulting byte string from the concatenation is written

crates/bindings/src/io.rs

@@ -1,27 +1,36 @@
+//! Defines macros for basic IO corresponding to what the standard library provides.
+//! These macros include `println`, `print`, `eprintln`, `eprint`, and `dbg`.
+
+/// Prints the provided arguments, terminated by a newline, as an `INFO` message to the console.
 #[doc(hidden)]
 #[macro_export]
 macro_rules! println {
     ($($arg:tt)*) => ($crate::log::info!($($arg)*))
 }
 
+/// Prints the provided arguments as an `INFO` message to the console.
 #[doc(hidden)]
 #[macro_export]
 macro_rules! print {
     ($($arg:tt)*) => ($crate::log::info!($($arg)*))
 }
 
+/// Prints the provided arguments, terminated by a newline, as an `ERROR` message to the console.
 #[doc(hidden)]
 #[macro_export]
 macro_rules! eprintln {
     ($($arg:tt)*) => ($crate::log::error!($($arg)*))
 }
 
+/// Prints the provided arguments as an `ERROR` message to the console.
 #[doc(hidden)]
 #[macro_export]
 macro_rules! eprint {
     ($($arg:tt)*) => ($crate::log::error!($($arg)*))
 }
 
+/// Functions like the standard library's `dbg!` macro
+/// but prints as a `DEBUG` message to the console.
 #[macro_export]
 macro_rules! dbg {
     // NOTE: We cannot use `concat!` to make a static string as a format argument