Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies between league admin info and league info displayed to players #330

Closed
alexmitrani opened this issue Jan 5, 2019 · 6 comments

Comments

@alexmitrani
Copy link

alexmitrani commented Jan 5, 2019

in the 9x9 league....
on the admin side:

  • the komi was set to 5.5
  • byo-yomi 30s (minimum 3 periods).

On the player side, the info page says:

  • komi 6.5
  • minimum of 5 * 30s byo-yomi.
    I assumed the admin version was write, we will see if a game with 3 m + 30s with 5.5 komi is league valid or not.
    thanks
@alexmitrani
Copy link
Author

I think some of this also affects other leagues - players told minimum of 5 byo-yomi of 30s but admin info says minimum is 3 periods.

@alexmitrani
Copy link
Author

the 9x9 game with 3 mins + 3*30 seconds byo-yomi and komi 5.5 was scraped and considered league valid.

@climu
Copy link
Owner

climu commented Jan 6, 2019

Thanks for the heads up. Yes admin version was right. I forgot to update the public infos page.

Regarding the komi, it's just that the info page was not reading the setting at all (komi setting was introduce not that long ago). It is fixed now.

Regarding time settings: there is no setting at this time for the number of byo yomi periods. It's hardcoded at 3 but we asked players to set up 5. That's a bug.

if byo['n'] < 3 or byo['t'] < event.additional_time:

I fixed the info page so it reflect the actual rules and get rid of inconsistencies.

Questions remaining is: Do we want a setting for that? If not, do we want 3 or 5?

@climu
Copy link
Owner

climu commented Jan 8, 2019

I close since inconsistencies are no more and remind the open question:
Do we want a setting for the number of byoyomi periods? If not, do we want 3 or 5?

@d-korni
Copy link

d-korni commented Jan 20, 2019

I would suggest 5 for 19x19 and 3 for 9x9.

@alexmitrani
Copy link
Author

See #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants