-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistencies between league admin info and league info displayed to players #330
Comments
I think some of this also affects other leagues - players told minimum of 5 byo-yomi of 30s but admin info says minimum is 3 periods. |
the 9x9 game with 3 mins + 3*30 seconds byo-yomi and komi 5.5 was scraped and considered league valid. |
Thanks for the heads up. Yes admin version was right. I forgot to update the public infos page. Regarding the komi, it's just that the info page was not reading the setting at all (komi setting was introduce not that long ago). It is fixed now. Regarding time settings: there is no setting at this time for the number of byo yomi periods. It's hardcoded at openstudyroom/league/models.py Line 490 in 9a688ff
I fixed the info page so it reflect the actual rules and get rid of inconsistencies. Questions remaining is: Do we want a setting for that? If not, do we want 3 or 5? |
I close since inconsistencies are no more and remind the open question: |
I would suggest 5 for 19x19 and 3 for 9x9. |
See #335 |
in the 9x9 league....
on the admin side:
On the player side, the info page says:
I assumed the admin version was write, we will see if a game with 3 m + 30s with 5.5 komi is league valid or not.
thanks
The text was updated successfully, but these errors were encountered: