Add roslint.

Author: mikepurvis

CMakeLists.txt

@@ -1,11 +1,14 @@
 cmake_minimum_required(VERSION 2.8.3)
 project(robot_upstart)
 
-find_package(catkin)
+find_package(catkin REQUIRED COMPONENTS roslint)
 
 catkin_package()
 catkin_python_setup()
 
+roslint_python()
+roslint_add_test()
+
 file(GLOB SCRIPTS scripts/*)
 install(PROGRAMS ${SCRIPTS} DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION})
 install(DIRECTORY templates DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION})

package.xml

@@ -13,6 +13,7 @@
   <license>BSD</license>
 
   <buildtool_depend>catkin</buildtool_depend>
+  <build_depend>roslint</build_depend>
   <run_depend>daemontools</run_depend>
   <run_depend>roslaunch</run_depend>
   <run_depend>xacro</run_depend>

src/robot_upstart/__init__.py

@@ -1,4 +1,4 @@
-# Software License Agreement (BSD) 
+# Software License Agreement (BSD)
 #
 # @author    Mike Purvis <[email protected]>
 # @copyright (c) 2015, Clearpath Robotics, Inc., All rights reserved.

src/robot_upstart/job.py

@@ -1,4 +1,4 @@
-# Software License Agreement (BSD) 
+# Software License Agreement (BSD)
 #
 # @author    Mike Purvis <[email protected]>
 # @copyright (c) 2015, Clearpath Robotics, Inc., All rights reserved.
@@ -25,7 +25,10 @@
 This file defines the Job class, which is the primary code API to robot_upstart.
 """
 
-import getpass, os, pickle, subprocess
+import getpass
+import os
+import pickle
+import subprocess
 from glob import glob as glob_files
 
 from catkin.find_in_workspaces import find_in_workspaces
@@ -36,8 +39,8 @@
 class Job(object):
     """ Represents a ROS configuration to launch on machine startup. """
 
-    def __init__(self, name="ros", interface=None, user=None, workspace_setup=None, \
-            rosdistro=None, master_uri="http://127.0.0.1:11311", log_path="/tmp"):
+    def __init__(self, name="ros", interface=None, user=None, workspace_setup=None,
+                 rosdistro=None, master_uri="http://127.0.0.1:11311", log_path="/tmp"):
         """Construct a new Job definition.
 
         :param name: Name of job to create. Defaults to "ros", but you might
@@ -75,7 +78,7 @@ def __init__(self, name="ros", interface=None, user=None, workspace_setup=None,
 
         # Fall back on current workspace setup file if not explicitly specified.
         self.workspace_setup = workspace_setup or \
-                os.environ['CMAKE_PREFIX_PATH'].split(':')[0] + '/setup.bash'
+            os.environ['CMAKE_PREFIX_PATH'].split(':')[0] + '/setup.bash'
 
         # Fall back on current distro if not otherwise specified.
         self.rosdistro = rosdistro or os.environ['ROS_DISTRO']
@@ -143,7 +146,8 @@ def install(self, root="/", sudo="/usr/bin/sudo", provider=providers.upstart):
         installation_files = provider(root, self)
 
         create_files_exec = find_in_workspaces(project="robot_upstart",
-                path="scripts/create_files", first_match_only=True)
+                                               path="scripts/create_files",
+                                               first_match_only=True)
         print "Preparing to install files to the following paths:"
         for filename in sorted(installation_files.keys()):
             print "  %s" % filename
@@ -160,4 +164,3 @@ def install(self, root="/", sudo="/usr/bin/sudo", provider=providers.upstart):
             print "Installation of files succeeded."
         else:
             print "Error encountered installing files."
-

src/robot_upstart/providers.py

@@ -1,4 +1,4 @@
-# Software License Agreement (BSD) 
+# Software License Agreement (BSD)
 #
 # @author    Mike Purvis <[email protected]>
 # @copyright (c) 2015, Clearpath Robotics, Inc., All rights reserved.
@@ -43,17 +43,17 @@ def upstart(root, job):
     for filename in job.files:
         with open(filename) as f:
             dest_filename = os.path.join(job.job_path, os.path.basename(filename))
-            installation_files[dest_filename] = { "content": f.read() }
+            installation_files[dest_filename] = {"content": f.read()}
 
     # Share a single instance of the empy interpreter. Because it is outputting
     # to a StringIO, that object needs to be truncated between templates.
     output = StringIO.StringIO()
     interpreter = em.Interpreter(output=output, globals=job.__dict__.copy())
- 
+
     def do_template(template, output_file, chmod=644):
         with open(find_in_workspaces(project="robot_upstart", path=template)[0]) as f:
             interpreter.file(f)
-            installation_files[output_file] = { "content": output.getvalue(), "chmod": chmod }
+            installation_files[output_file] = {"content": output.getvalue(), "chmod": chmod}
             output.truncate(0)
 
     do_template("templates/job.conf.em", os.path.join(root, "etc/init", job.name + ".conf"), 755)