From d51d402b593977405fa1b74ea0d17f8b6f67af3d Mon Sep 17 00:00:00 2001 From: Nicholas Sherlock Date: Sat, 7 Jan 2017 11:35:36 +1300 Subject: [PATCH] Properly close the video file if rendering is aborted --- app/js/flightlog_video_renderer.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/js/flightlog_video_renderer.js b/app/js/flightlog_video_renderer.js index c4d7c02..7d193d1 100644 --- a/app/js/flightlog_video_renderer.js +++ b/app/js/flightlog_video_renderer.js @@ -133,7 +133,7 @@ function FlightLogVideoRenderer(flightLog, logParameters, videoOptions) { that.emit("complete", success, frameCount); } - function finishRender() { + function finishRender(success) { var complete; @@ -146,7 +146,7 @@ function FlightLogVideoRenderer(flightLog, logParameters, videoOptions) { } complete.then(function() { - notifyCompletion(true, frameIndex); + notifyCompletion(success, frameIndex); }); } @@ -162,7 +162,7 @@ function FlightLogVideoRenderer(flightLog, logParameters, videoOptions) { framesToRender = Math.min(workChunkSize, frameCount - frameIndex); if (cancel) { - notifyCompletion(false); + finishRender(false); return; } @@ -171,7 +171,7 @@ function FlightLogVideoRenderer(flightLog, logParameters, videoOptions) { that.emit("progress", frameIndex, frameCount, that.getWrittenSize()); if (frameIndex >= frameCount) { - finishRender(); + finishRender(true); } else { setTimeout(renderChunk, 0); }