Skip to content

Commit 5556d33

Browse files
authored
Merge pull request kubernetes#112846 from Richabanker/stability-fix-test
Add test for internal metric
2 parents e9f28c0 + b71d580 commit 5556d33

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

staging/src/k8s.io/component-base/metrics/collector_test.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ func TestBaseCustomCollector(t *testing.T) {
6363
var (
6464
alphaDesc = NewDesc("metric_alpha", "alpha metric", []string{"name"}, nil,
6565
ALPHA, "")
66+
internalDesc = NewDesc("metric_internal", "internal metrics", []string{"name"}, nil,
67+
INTERNAL, "")
6668
stableDesc = NewDesc("metric_stable", "stable metrics", []string{"name"}, nil,
6769
STABLE, "")
6870
deprecatedDesc = NewDesc("metric_deprecated", "stable deprecated metrics", []string{"name"}, nil,
@@ -72,7 +74,7 @@ func TestBaseCustomCollector(t *testing.T) {
7274
)
7375

7476
registry := newKubeRegistry(currentVersion)
75-
customCollector := newTestCustomCollector(alphaDesc, stableDesc, deprecatedDesc, hiddenDesc)
77+
customCollector := newTestCustomCollector(alphaDesc, internalDesc, stableDesc, deprecatedDesc, hiddenDesc)
7678

7779
if err := registry.CustomRegister(customCollector); err != nil {
7880
t.Fatalf("register collector failed with err: %v", err)
@@ -82,6 +84,9 @@ func TestBaseCustomCollector(t *testing.T) {
8284
# HELP metric_alpha [ALPHA] alpha metric
8385
# TYPE metric_alpha gauge
8486
metric_alpha{name="value"} 1
87+
# HELP metric_internal [INTERNAL] internal metrics
88+
# TYPE metric_internal gauge
89+
metric_internal{name="value"} 1
8590
# HELP metric_stable [STABLE] stable metrics
8691
# TYPE metric_stable gauge
8792
metric_stable{name="value"} 1
@@ -91,7 +96,7 @@ func TestBaseCustomCollector(t *testing.T) {
9196
`
9297

9398
err := testutil.GatherAndCompare(registry, strings.NewReader(expectedMetrics), alphaDesc.fqName,
94-
stableDesc.fqName, deprecatedDesc.fqName, hiddenDesc.fqName)
99+
internalDesc.fqName, stableDesc.fqName, deprecatedDesc.fqName, hiddenDesc.fqName)
95100
if err != nil {
96101
t.Fatal(err)
97102
}

0 commit comments

Comments
 (0)