Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone for wttr.in/Moon #56

Open
chubin opened this issue Oct 22, 2016 · 6 comments
Open

Timezone for wttr.in/Moon #56

chubin opened this issue Oct 22, 2016 · 6 comments

Comments

@chubin
Copy link
Owner

chubin commented Oct 22, 2016

At the moment, wttr.in/Moon show the Moon in the GMT+3 time.

Proposed changes:

  1. Use GMT by default
  2. Switch timezone using additional param:

http://wttr.in/Moon?TZ=EET

@opt9
Copy link

opt9 commented Jan 25, 2017

or

http://wttr.in/moon/london

@chubin
Copy link
Owner Author

chubin commented Oct 15, 2020

@martinbra Yet another interesting issue related to the Moon.
To fix this we need support for timezone in pyphoon.
Something like:

pyphoon -t Europe/London

If this option is supported in pyphoon, we can easily add support to wttr.in:

  • local time for the IP-address
  • switch of timezone from the query
  • switch of the location of the watch from the query as @opt9 proposes (by the way, it is interesting for the hemisphere too)

@martinbra
Copy link

That would be a nice learning project for me!
I think that if we add this functionality, we should also add hours and maybe even GMT offset to the call pyphoon 2020-10-09T21:00 (oops it already works: pyphoon 2020-10-09T22:00 shows another phase). I tried without success to parse with "Z+01" and some other formats trying to check if a timezone could be passed, but i still have to check the code...

Should we use GMT or UTC name as standard?

@chubin
Copy link
Owner Author

chubin commented Oct 17, 2020

I believe we already use UTC, and it it the right choice for a internet service like ours.

I think the plan here should be:

  • open a new issue in pyphonn
  • add the new long option (--timezone)
  • make it show the output for the timezone if specified (with an additional message, like for hemispheres)
  • make a PR/merge it
  • activate the feature for wttr.in/Moon

Options to select timezone in the query:

  • wttr.in/Moon?Z (use local time zone)
  • wttr.in/Moon@2010-01-01,London (date and location)
  • wttr.in/Moon?timezone=europe/london (timezone specified explicitly)

I think we want to support all thre

@martinbra
Copy link

chubin/pyphoon#33 created.

@victorz
Copy link

victorz commented Mar 14, 2023

Is this why e.g. today wttr.in is giving me Waxing Gibbous at 62 % illumination, whereas nineplanets.org is giving me ~60 % and timeanddate.com is giving me ~58 %?

It's at the most over 4 % off, depending on who's correct. Would someone be able to explain the discrepancy between these services?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants