Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese date format #423

Closed
liyishuai opened this issue Mar 24, 2020 · 2 comments
Closed

Chinese date format #423

liyishuai opened this issue Mar 24, 2020 · 2 comments

Comments

@liyishuai
Copy link

liyishuai commented Mar 24, 2020

Previously mentioned in #83 (comment)

The current date +"%a %d %B" is hard to read in Chinese, as %a and %d are both numbers.
Consider changing it to date +"%B%-d日%A":

  • $ LANG=zh_CN date +"%B%-d日%A"

    三月23日星期一

  • LANG=zh_TW date +"%B%-d日%A"

    3月23日週一

@chubin
Copy link
Owner

chubin commented Mar 29, 2020

Thank you for helping with the chinese translation @liyishuai
We have a lot of minor issues with Chinese, what is holding us back
from having the full fledged Chinese support.

I've changed it to "%b%d日%A" now:

────┤3月31日星期二├───

I think that the %a part looks somehow wrong.

Please check curl zh.wttr.in

@liyishuai
Copy link
Author

LGTM. Thanks!

chubin added a commit that referenced this issue May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants