Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] tide level #31

Open
iammyr opened this issue Apr 5, 2016 · 11 comments
Open

[Feature Request] tide level #31

iammyr opened this issue Apr 5, 2016 · 11 comments

Comments

@iammyr
Copy link

iammyr commented Apr 5, 2016

First of all this is amazing! Thank you so much :)
I just thought it would be awesome to have tide levels showing as well, given their relation to the moon phases. Thanks again

@ScrumpyJack
Copy link

+1

1 similar comment
@Kefedric
Copy link

+1

@chubin
Copy link
Owner

chubin commented Jul 15, 2020

@Kefedric @ScrumpyJack @iammyr

It is an interesting feature; we should add it.

My questions:

  1. what should be used as input? Location name? The same as for weather?
  2. What should be output? Current tide level? tide level forecast?
  3. Is it for the one-line output only? Or should be added as an additional line to the v2 view (v2.wttr.in)?

@Kefedric
Copy link

@chubin

  1. For input I sugest to keep it simple and keep the same as for weather.
  2. For ouput I sugest tide forecast for the current day on the nearest port with ( Low tide (AM time / AM level : PM time : PM level) High tide (AM time / AM level : PM time : PM level) )
  3. For one-line output sure, for the v2 view I’am not sure because if you check weather inland you have no intrest for tide.

@iago-lito
Copy link
Contributor

Yeah, what's the expected output if I (implicitly) ask tide for Ulaanbaatar? Is there an arbitrary 'inland/shore' line to draw?

@Kefedric
Copy link

@iago-lito I think (as previously mentioned) that tide should only get result of a nearby harbor.

I imagine you could make a querry base on locations gps coordinates and compare it to a list of harbor coordinates (with tide data)
if your location is in the range of a harbor then you display the tide info.
and if there are multiple then we must think of a funcitons wich finds the nearest.

@iago-lito
Copy link
Contributor

Okay. Not sure what data is available in wttr backend about harbors and shores, though. Does any city have a boolean tag explicitly stating "I'm a harbor" ?

Alternately, if the coasts polygons lines are available, any city has gps coordinates so its distance to shore can be compared to an arbitrary threshold (say, 30km?) to decide whether or not to display the tide information. This will also work for cities that happen to be close from the shore, but not close to a harbor.

@Kefedric
Copy link

@iago-lito
Sorry but I have no knowledge on the backend data.
What I know, is where I live, tide data are available by harbor.

@chubin
Copy link
Owner

chubin commented Sep 16, 2020

I think we have two options here:

  1. The tide-level must be queried explicitly (%-notation, or {{tide}}), for one-line output;
  2. For the locations where tide-level makes sense (locations on shore), it could be displayed automatically in some views (like v2).

The first one would be much more simple to implement, and probably would satisfy most users.

For the one-line mode, perhaps we need to support additional arguments,
or do you think al users would like to have the same output format
Low tide (AM time / AM level : PM time : PM level) High tide (AM time / AM level : PM time : PM level)
?

@Kefedric
Copy link

@chubin Indeed one-line mode should be enough for most users.

And for the argument maybe one for low tide display and another for low tide ?

@chubin
Copy link
Owner

chubin commented Oct 14, 2020

Accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants