Update to Chromium version 130.0.6723.0 (#1356013)

Author: magreenblatt

CHROMIUM_BUILD_COMPATIBILITY.txt

@@ -7,5 +7,5 @@
 # https://bitbucket.org/chromiumembedded/cef/wiki/BranchesAndBuilding
 
 {
-  'chromium_checkout': 'refs/tags/129.0.6668.0'
+  'chromium_checkout': 'refs/tags/130.0.6723.0'
 }

include/cef_api_hash.h

@@ -42,13 +42,13 @@
 // way that may cause binary incompatibility with other builds. The universal
 // hash value will change if any platform is affected whereas the platform hash
 // values will change only if that particular platform is affected.
-#define CEF_API_HASH_UNIVERSAL "3c4bef13c1801f001305b1bc3af84039b2426943"
+#define CEF_API_HASH_UNIVERSAL "9717d7221d63adfd79ee52e2a31c9ac7acdd6d50"
 #if defined(OS_WIN)
-#define CEF_API_HASH_PLATFORM "10e56374e7d422b45eec31ae5d2aa7ef5288621c"
+#define CEF_API_HASH_PLATFORM "072a4fe61a512f21fd0d664495902fca6ec2193b"
 #elif defined(OS_MAC)
-#define CEF_API_HASH_PLATFORM "ae9f14019f456db6ad8059f17d1dfd484d4a08d7"
+#define CEF_API_HASH_PLATFORM "ee7f0e9247add8df0827d02da32559e38e8079d0"
 #elif defined(OS_LINUX)
-#define CEF_API_HASH_PLATFORM "84dcdea90daf46d0ba611b1d0f3e42666fb3382d"
+#define CEF_API_HASH_PLATFORM "88996e58ee062016efd054bfbafd03dd3daa99ed"
 #endif
 
 #ifdef __cplusplus

include/internal/cef_types.h

@@ -3627,20 +3627,22 @@ typedef enum {
   CEF_PERMISSION_TYPE_DISK_QUOTA = 1 << 7,
   CEF_PERMISSION_TYPE_LOCAL_FONTS = 1 << 8,
   CEF_PERMISSION_TYPE_GEOLOCATION = 1 << 9,
-  CEF_PERMISSION_TYPE_IDENTITY_PROVIDER = 1 << 10,
-  CEF_PERMISSION_TYPE_IDLE_DETECTION = 1 << 11,
-  CEF_PERMISSION_TYPE_MIC_STREAM = 1 << 12,
-  CEF_PERMISSION_TYPE_MIDI_SYSEX = 1 << 13,
-  CEF_PERMISSION_TYPE_MULTIPLE_DOWNLOADS = 1 << 14,
-  CEF_PERMISSION_TYPE_NOTIFICATIONS = 1 << 15,
-  CEF_PERMISSION_TYPE_KEYBOARD_LOCK = 1 << 16,
-  CEF_PERMISSION_TYPE_POINTER_LOCK = 1 << 17,
-  CEF_PERMISSION_TYPE_PROTECTED_MEDIA_IDENTIFIER = 1 << 18,
-  CEF_PERMISSION_TYPE_REGISTER_PROTOCOL_HANDLER = 1 << 19,
-  CEF_PERMISSION_TYPE_STORAGE_ACCESS = 1 << 20,
-  CEF_PERMISSION_TYPE_VR_SESSION = 1 << 21,
-  CEF_PERMISSION_TYPE_WINDOW_MANAGEMENT = 1 << 22,
-  CEF_PERMISSION_TYPE_FILE_SYSTEM_ACCESS = 1 << 23,
+  CEF_PERMISSION_TYPE_HAND_TRACKING = 1 << 10,
+  CEF_PERMISSION_TYPE_IDENTITY_PROVIDER = 1 << 11,
+  CEF_PERMISSION_TYPE_IDLE_DETECTION = 1 << 12,
+  CEF_PERMISSION_TYPE_MIC_STREAM = 1 << 13,
+  CEF_PERMISSION_TYPE_MIDI_SYSEX = 1 << 14,
+  CEF_PERMISSION_TYPE_MULTIPLE_DOWNLOADS = 1 << 15,
+  CEF_PERMISSION_TYPE_NOTIFICATIONS = 1 << 16,
+  CEF_PERMISSION_TYPE_KEYBOARD_LOCK = 1 << 17,
+  CEF_PERMISSION_TYPE_POINTER_LOCK = 1 << 18,
+  CEF_PERMISSION_TYPE_PROTECTED_MEDIA_IDENTIFIER = 1 << 19,
+  CEF_PERMISSION_TYPE_REGISTER_PROTOCOL_HANDLER = 1 << 20,
+  CEF_PERMISSION_TYPE_STORAGE_ACCESS = 1 << 21,
+  CEF_PERMISSION_TYPE_VR_SESSION = 1 << 22,
+  CEF_PERMISSION_TYPE_WEB_APP_INSTALLATION = 1 << 23,
+  CEF_PERMISSION_TYPE_WINDOW_MANAGEMENT = 1 << 24,
+  CEF_PERMISSION_TYPE_FILE_SYSTEM_ACCESS = 1 << 25,
 } cef_permission_request_types_t;
 
 ///

include/internal/cef_types_content_settings.h

@@ -445,28 +445,35 @@ typedef enum {
   /// ALLOW: Protections disabled.
   CEF_CONTENT_SETTING_TYPE_TRACKING_PROTECTION,
 
-  // With this permission, when the application calls `getDisplayMedia()`, a
-  // system audio track can be returned without showing the display media
-  // selection picker. The application can explicitly specify
-  // `systemAudio: 'exclude'` or `video: true` to still show the display media
-  // selection picker if needed. Please note that the setting only works for
-  // WebUI.
+  /// With this permission, when the application calls `getDisplayMedia()`, a
+  /// system audio track can be returned without showing the display media
+  /// selection picker. The application can explicitly specify
+  /// `systemAudio: 'exclude'` or `video: true` to still show the display media
+  /// selection picker if needed. Please note that the setting only works for
+  /// WebUI.
   CEF_CONTENT_SETTING_TYPE_DISPLAY_MEDIA_SYSTEM_AUDIO,
 
-  // Whether to use the higher-tier v8 optimizers for running JavaScript on the
-  // page.
+  /// Whether to use the higher-tier v8 optimizers for running JavaScript on the
+  /// page.
   CEF_CONTENT_SETTING_TYPE_JAVASCRIPT_OPTIMIZER,
 
-  // Content Setting for the Storage Access Headers persistent origin trial that
-  // allows origins to opt into the storage access header behavior. Should be
-  // scoped to `REQUESTING_ORIGIN_AND_TOP_SCHEMEFUL_SITE_SCOPE` in order to
-  // correspond to the design of persistent origin trials. See also:
-  // https://github.com/cfredric/storage-access-headers
-  // ALLOW: storage access request headers will be attached to cross-site
-  //        requests, and url requests will look for response headers from
-  //        origins to retry a request or load with storage access.
-  // BLOCK (default): no effect.
+  /// Content Setting for the Storage Access Headers persistent origin trial
+  /// that allows origins to opt into the storage access header behavior. Should
+  /// be scoped to `REQUESTING_ORIGIN_AND_TOP_SCHEMEFUL_SITE_SCOPE` in order to
+  /// correspond to the design of persistent origin trials. See also:
+  /// https://github.com/cfredric/storage-access-headers
+  /// ALLOW: storage access request headers will be attached to cross-site
+  ///        requests, and url requests will look for response headers from
+  ///        origins to retry a request or load with storage access.
+  /// BLOCK (default): no effect.
   CEF_CONTENT_SETTING_TYPE_STORAGE_ACCESS_HEADER_ORIGIN_TRIAL,
+
+  /// Whether or not sites can request Hand Tracking data within WebXR Sessions.
+  CEF_CONTENT_SETTING_TYPE_HAND_TRACKING,
+
+  /// Website setting to indicate whether user has opted in to allow web apps to
+  /// install other web apps.
+  CEF_CONTENT_SETTING_TYPE_WEB_APP_INSTALLATION,
 } cef_content_setting_types_t;
 
 ///

libcef/browser/alloy/alloy_browser_host_impl.cc

@@ -940,17 +940,19 @@ content::WebContents* AlloyBrowserHostImpl::OpenURLFromTab(
   return nullptr;
 }
 
-void AlloyBrowserHostImpl::AddNewContents(
+content::WebContents* AlloyBrowserHostImpl::AddNewContents(
     content::WebContents* source,
     std::unique_ptr<content::WebContents> new_contents,
     const GURL& target_url,
     WindowOpenDisposition disposition,
     const blink::mojom::WindowFeatures& window_features,
     bool user_gesture,
     bool* was_blocked) {
+  auto* new_contents_ptr = new_contents.get();
   platform_delegate_->AddNewContents(source, std::move(new_contents),
                                      target_url, disposition, window_features,
                                      user_gesture, was_blocked);
+  return new_contents_ptr;
 }
 
 void AlloyBrowserHostImpl::LoadingStateChanged(content::WebContents* source,

libcef/browser/alloy/alloy_browser_host_impl.h

@@ -179,13 +179,14 @@ class AlloyBrowserHostImpl : public CefBrowserHostBase,
       const content::OpenURLParams& params,
       base::OnceCallback<void(content::NavigationHandle&)>
           navigation_handle_callback) override;
-  void AddNewContents(content::WebContents* source,
-                      std::unique_ptr<content::WebContents> new_contents,
-                      const GURL& target_url,
-                      WindowOpenDisposition disposition,
-                      const blink::mojom::WindowFeatures& window_features,
-                      bool user_gesture,
-                      bool* was_blocked) override;
+  content::WebContents* AddNewContents(
+      content::WebContents* source,
+      std::unique_ptr<content::WebContents> new_contents,
+      const GURL& target_url,
+      WindowOpenDisposition disposition,
+      const blink::mojom::WindowFeatures& window_features,
+      bool user_gesture,
+      bool* was_blocked) override;
   void LoadingStateChanged(content::WebContents* source,
                            bool should_show_loading_ui) override;
   void CloseContents(content::WebContents* source) override;

libcef/browser/chrome/chrome_content_browser_client_cef.cc

@@ -51,7 +51,7 @@ namespace {
 void HandleExternalProtocolHelper(
     ChromeContentBrowserClientCef* self,
     content::WebContents::Getter web_contents_getter,
-    int frame_tree_node_id,
+    content::FrameTreeNodeId frame_tree_node_id,
     content::NavigationUIData* navigation_data,
     bool is_primary_main_frame,
     bool is_in_fenced_frame_tree,
@@ -343,7 +343,7 @@ void ChromeContentBrowserClientCef::WillCreateURLLoaderFactory(
 bool ChromeContentBrowserClientCef::HandleExternalProtocol(
     const GURL& url,
     content::WebContents::Getter web_contents_getter,
-    int frame_tree_node_id,
+    content::FrameTreeNodeId frame_tree_node_id,
     content::NavigationUIData* navigation_data,
     bool is_primary_main_frame,
     bool is_in_fenced_frame_tree,
@@ -372,7 +372,7 @@ bool ChromeContentBrowserClientCef::HandleExternalProtocol(
 
 bool ChromeContentBrowserClientCef::HandleExternalProtocol(
     content::WebContents::Getter web_contents_getter,
-    int frame_tree_node_id,
+    content::FrameTreeNodeId frame_tree_node_id,
     content::NavigationUIData* navigation_data,
     bool is_primary_main_frame,
     bool is_in_fenced_frame_tree,

libcef/browser/chrome/chrome_content_browser_client_cef.h

@@ -78,7 +78,7 @@ class ChromeContentBrowserClientCef : public ChromeContentBrowserClient {
   bool HandleExternalProtocol(
       const GURL& url,
       content::WebContents::Getter web_contents_getter,
-      int frame_tree_node_id,
+      content::FrameTreeNodeId frame_tree_node_id,
       content::NavigationUIData* navigation_data,
       bool is_primary_main_frame,
       bool is_in_fenced_frame_tree,
@@ -91,7 +91,7 @@ class ChromeContentBrowserClientCef : public ChromeContentBrowserClient {
       override;
   bool HandleExternalProtocol(
       content::WebContents::Getter web_contents_getter,
-      int frame_tree_node_id,
+      content::FrameTreeNodeId frame_tree_node_id,
       content::NavigationUIData* navigation_data,
       bool is_primary_main_frame,
       bool is_in_fenced_frame_tree,

libcef/browser/frame_host_impl.cc

@@ -469,8 +469,8 @@ void CefFrameHostImpl::ExecuteJavaScriptWithUserGestureForTests(
 
   content::RenderFrameHost* rfh = GetRenderFrameHost();
   if (rfh) {
-    rfh->ExecuteJavaScriptWithUserGestureForTests(javascript,
-                                                  base::NullCallback());
+    rfh->ExecuteJavaScriptWithUserGestureForTests(
+        javascript, base::NullCallback(), content::ISOLATED_WORLD_ID_GLOBAL);
   }
 }
 

libcef/browser/net_service/cookie_helper.cc

@@ -283,10 +283,7 @@ void SaveCookies(const CefBrowserContext::Getter& browser_context_getter,
 
   // Match the logic in
   // URLRequestHttpJob::SaveCookiesAndNotifyHeadersComplete.
-  base::Time response_date;
-  if (!headers->GetDateValue(&response_date)) {
-    response_date = base::Time();
-  }
+  const auto response_date = headers->GetDateValue();
 
   const std::string_view name(net_service::kHTTPSetCookieHeaderName);
   std::string cookie_string;
@@ -299,8 +296,7 @@ void SaveCookies(const CefBrowserContext::Getter& browser_context_getter,
 
     net::CookieInclusionStatus returned_status;
     std::unique_ptr<net::CanonicalCookie> cookie = net::CanonicalCookie::Create(
-        request.url, cookie_string, base::Time::Now(),
-        std::make_optional(response_date),
+        request.url, cookie_string, base::Time::Now(), response_date,
         /*cookie_partition_key=*/std::nullopt, net::CookieSourceType::kHTTP,
         &returned_status);
     if (!returned_status.IsInclude()) {

libcef/browser/net_service/resource_request_handler_wrapper.cc

@@ -1360,7 +1360,7 @@ std::unique_ptr<InterceptedRequestHandler> CreateInterceptedRequestHandler(
 
 std::unique_ptr<InterceptedRequestHandler> CreateInterceptedRequestHandler(
     content::WebContents::Getter web_contents_getter,
-    int frame_tree_node_id,
+    content::FrameTreeNodeId frame_tree_node_id,
     const network::ResourceRequest& request,
     const base::RepeatingClosure& unhandled_request_callback) {
   CEF_REQUIRE_UIT();

libcef/browser/net_service/resource_request_handler_wrapper.h

@@ -41,7 +41,7 @@ std::unique_ptr<InterceptedRequestHandler> CreateInterceptedRequestHandler(
 // ProxyURLLoaderFactory::CreateProxy. Called on the UI thread only.
 std::unique_ptr<InterceptedRequestHandler> CreateInterceptedRequestHandler(
     content::WebContents::Getter web_contents_getter,
-    int frame_tree_node_id,
+    content::FrameTreeNodeId frame_tree_node_id,
     const network::ResourceRequest& request,
     const base::RepeatingClosure& unhandled_request_callback);
 

libcef/browser/osr/osr_accessibility_util.cc

@@ -107,7 +107,7 @@ struct PopulateAxNodeAttributes {
       case ax::mojom::IntAttribute::kActivedescendantId:
       case ax::mojom::IntAttribute::kInPageLinkTargetId:
       case ax::mojom::IntAttribute::kErrormessageIdDeprecated:
-      case ax::mojom::IntAttribute::kDOMNodeId:
+      case ax::mojom::IntAttribute::kDOMNodeIdDeprecated:
       case ax::mojom::IntAttribute::kDropeffectDeprecated:
       case ax::mojom::IntAttribute::kMemberOfId:
       case ax::mojom::IntAttribute::kNextFocusId:

libcef/browser/permission_prompt.cc

@@ -208,6 +208,8 @@ cef_permission_request_types_t GetCefRequestType(
       return CEF_PERMISSION_TYPE_LOCAL_FONTS;
     case permissions::RequestType::kGeolocation:
       return CEF_PERMISSION_TYPE_GEOLOCATION;
+    case permissions::RequestType::kHandTracking:
+      return CEF_PERMISSION_TYPE_HAND_TRACKING;
     case permissions::RequestType::kIdentityProvider:
       return CEF_PERMISSION_TYPE_IDENTITY_PROVIDER;
     case permissions::RequestType::kIdleDetection:
@@ -236,6 +238,8 @@ cef_permission_request_types_t GetCefRequestType(
       return CEF_PERMISSION_TYPE_TOP_LEVEL_STORAGE_ACCESS;
     case permissions::RequestType::kVrSession:
       return CEF_PERMISSION_TYPE_VR_SESSION;
+    case permissions::RequestType::kWebAppInstallation:
+      return CEF_PERMISSION_TYPE_WEB_APP_INSTALLATION;
     case permissions::RequestType::kWindowManagement:
       return CEF_PERMISSION_TYPE_WINDOW_MANAGEMENT;
     case permissions::RequestType::kFileSystemAccess:

libcef_dll/cpptoc/views/window_delegate_cpptoc.cc

@@ -13,6 +13,7 @@
 //
 
 #include "libcef_dll/cpptoc/views/window_delegate_cpptoc.h"
+
 #include "libcef_dll/ctocpp/views/view_ctocpp.h"
 #include "libcef_dll/ctocpp/views/window_ctocpp.h"
 #include "libcef_dll/shutdown_checker.h"

libcef_dll/ctocpp/views/window_delegate_ctocpp.cc

@@ -13,6 +13,7 @@
 //
 
 #include "libcef_dll/ctocpp/views/window_delegate_ctocpp.h"
+
 #include "libcef_dll/cpptoc/views/view_cpptoc.h"
 #include "libcef_dll/cpptoc/views/window_cpptoc.h"
 #include "libcef_dll/shutdown_checker.h"

patch/patch.cfg

@@ -184,6 +184,11 @@ patches = [
     #
     # Route |parent_widget| to MenuHost for OSR context menu Widget creation.
     # https://github.com/chromiumembedded/cef/issues/3330
+    #
+    # Make views::View::GetHeightForWidth virtual so that it can be overridden
+    # by CefViewView. Alternately, we could implement the same functionality
+    # by removing CefViewDelegate::GetHeightForWidth and adding an optional
+    # |available_size| argument to CefViewDelegate::GetPreferredSize.
     'name': 'views_1749_2102_3330',
   },
   {
@@ -230,6 +235,13 @@ patches = [
     # Linux: Fix duplicate symbol error for tab_network_state.cc
     # https://issuetracker.google.com/issues/353628440#comment8
     #
+    # Linux: Fix duplicate symbol error for automation_manager_aura.cc
+    # https://chromium-review.googlesource.com/c/chromium/src/+/5893679
+    #
+    # Linux: Fix duplicate symbol error for
+    # chrome_bluetooth_chooser_controller.cc
+    # https://chromium-review.googlesource.com/c/chromium/src/+/5894080
+    #
     # Avoid duplicate window from DevTools when CEF handles the open via
     # OnOpenURLFromTab.
     # https://github.com/chromiumembedded/cef/issues/3735
@@ -741,8 +753,8 @@ patches = [
     'name': 'third_party_sentencepiece_3616'
   },
   {
-    # Windows: Add missing check in base/profiler/stack_copier.cc to fix
-    # compilation error of cef_sandbox.
-    'name': 'win_sandbox_stack_copier'
+    # win: Add missing <limits> include for cef_sandbox build.
+    # https://chromium-review.googlesource.com/c/chromium/src/+/5891459
+    'name': 'win_base_pa_oom_5891459'
   }
 ]

patch/patches/base_command_line_1872.patch

@@ -1,5 +1,5 @@
 diff --git base/command_line.cc base/command_line.cc
-index 853a7fa23c725..33654c0b63dc1 100644
+index fd6792a0599e2..4cf7bb3ceb226 100644
 --- base/command_line.cc
 +++ base/command_line.cc
 @@ -389,11 +389,10 @@ void CommandLine::AppendSwitchNative(std::string_view switch_string,

patch/patches/base_sandbox_2743.patch

@@ -1,5 +1,5 @@
 diff --git base/BUILD.gn base/BUILD.gn
-index 2561c2726d27e..f666f5b804c4c 100644
+index d6dbc2c38b401..0e0a5cc086291 100644
 --- base/BUILD.gn
 +++ base/BUILD.gn
 @@ -41,6 +41,7 @@ import("//build/nocompile.gni")
@@ -10,7 +10,7 @@ index 2561c2726d27e..f666f5b804c4c 100644
  import("//testing/libfuzzer/fuzzer_test.gni")
  import("//testing/test.gni")
 
-@@ -1519,7 +1520,11 @@ component("base") {
+@@ -1507,7 +1508,11 @@ component("base") {
      "hash/md5_constexpr_internal.h",
      "hash/sha1.h",
    ]
@@ -23,7 +23,7 @@ index 2561c2726d27e..f666f5b804c4c 100644
      sources += [
        "hash/md5_nacl.cc",
        "hash/md5_nacl.h",
-@@ -1942,6 +1947,12 @@ component("base") {
+@@ -1932,6 +1937,12 @@ component("base") {
        defines += [ "COM_INIT_CHECK_HOOK_DISABLED" ]
      }