Update to Chromium version 128.0.6613.0 (#1331488)

Author: magreenblatt

BUILD.gn

@@ -1328,8 +1328,9 @@ make_pack_header("strings") {
     "$root_gen_dir/components/strings/grit/components_strings.h",
     "$root_gen_dir/extensions/strings/grit/extensions_strings.h",
     "$root_gen_dir/services/strings/grit/services_strings.h",
-    "$root_gen_dir/third_party/blink/public/strings/grit/blink_accessibility_strings.h",
     "$root_gen_dir/third_party/blink/public/strings/grit/blink_strings.h",
+    "$root_gen_dir/ui/strings/grit/app_locale_settings.h",
+    "$root_gen_dir/ui/strings/grit/auto_image_annotation_strings.h",
     "$root_gen_dir/ui/strings/grit/ui_strings.h",
   ]
 
@@ -1346,8 +1347,8 @@ make_pack_header("strings") {
     "//extensions/strings",
     "//services/strings",
     "//third_party/blink/public/strings",
-    "//third_party/blink/public/strings:accessibility_strings",
     "//ui/strings:app_locale_settings",
+    "//ui/strings:auto_image_annotation_strings",
     "//ui/strings:ui_strings",
   ]
 }
@@ -1471,50 +1472,32 @@ if (is_mac) {
     ]
   }
 
-  if (use_egl) {
-    # Add the ANGLE .dylibs in the MODULE_DIR of the Framework app bundle.
-    bundle_data("cef_framework_angle_binaries") {
-      sources = [
-        "$root_out_dir/egl_intermediates/libEGL.dylib",
-        "$root_out_dir/egl_intermediates/libGLESv2.dylib",
-      ]
-      outputs = [
-        "{{bundle_contents_dir}}/Libraries/{{source_file_part}}",
-      ]
-      public_deps = [
-        "//ui/gl:angle_library_copy",
-      ]
-    }
-
-    # Add the SwiftShader .dylibs in the MODULE_DIR of the Framework app bundle.
-    bundle_data("cef_framework_swiftshader_binaries") {
-      sources = [
-        "$root_out_dir/vk_intermediates/libvk_swiftshader.dylib",
-        "$root_out_dir/vk_intermediates/vk_swiftshader_icd.json",
-      ]
-      outputs = [
-        "{{bundle_contents_dir}}/Libraries/{{source_file_part}}",
-      ]
-      public_deps = [
-        "//ui/gl:swiftshader_vk_library_copy",
-      ]
-    }
-  }
-
-  group("cef_framework_angle_library") {
-    if (use_egl) {
-      deps = [
-        ":cef_framework_angle_binaries",
-      ]
-    }
+  # Add the ANGLE .dylibs in the MODULE_DIR of the Framework app bundle.
+  bundle_data("cef_framework_angle_binaries") {
+    sources = [
+      "$root_out_dir/egl_intermediates/libEGL.dylib",
+      "$root_out_dir/egl_intermediates/libGLESv2.dylib",
+    ]
+    outputs = [
+      "{{bundle_contents_dir}}/Libraries/{{source_file_part}}",
+    ]
+    public_deps = [
+      "//ui/gl:angle_library_copy",
+    ]
   }
 
-  group("cef_framework_swiftshader_library") {
-    if (use_egl) {
-      deps = [
-        ":cef_framework_swiftshader_binaries",
-      ]
-    }
+  # Add the SwiftShader .dylibs in the MODULE_DIR of the Framework app bundle.
+  bundle_data("cef_framework_swiftshader_binaries") {
+    sources = [
+      "$root_out_dir/vk_intermediates/libvk_swiftshader.dylib",
+      "$root_out_dir/vk_intermediates/vk_swiftshader_icd.json",
+    ]
+    outputs = [
+      "{{bundle_contents_dir}}/Libraries/{{source_file_part}}",
+    ]
+    public_deps = [
+      "//ui/gl:swiftshader_vk_library_copy",
+    ]
   }
 
   mac_framework_bundle("cef_framework") {
@@ -1538,9 +1521,9 @@ if (is_mac) {
               gypi_paths.autogen_library_side
 
     deps = [
-      ":cef_framework_angle_library",
+      ":cef_framework_angle_binaries",
       ":cef_framework_resources",
-      ":cef_framework_swiftshader_library",
+      ":cef_framework_swiftshader_binaries",
       ":libcef_static",
       ":libcef_test_support",
     ]

CHROMIUM_BUILD_COMPATIBILITY.txt

@@ -7,5 +7,5 @@
 # https://bitbucket.org/chromiumembedded/cef/wiki/BranchesAndBuilding
 
 {
-  'chromium_checkout': 'refs/tags/127.0.6533.0'
+  'chromium_checkout': 'refs/tags/128.0.6613.0'
 }

CHROMIUM_UPDATE.txt

@@ -27,17 +27,6 @@
   # Files in the chromium/src directory that should be evaluated for changes.
   # Similar changes may need to be applied to the CEF source code.
   'files': [
-    'chrome/browser/browser_process.h',
-    'chrome/browser/extensions/api/tabs/tabs_api.*',
-    'chrome/browser/extensions/chrome_component_extension_resource_manager.*',
-    'chrome/browser/extensions/chrome_extension_web_contents_observer.*',
-    'chrome/browser/extensions/component_loader.*',
-    'chrome/browser/extensions/extension_service.*',
-    'chrome/browser/profiles/profile.h',
-    'chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.*',
-    'chrome/common/extensions/api/*_features.json',
-    'chrome/renderer/chrome_content_renderer_client.*',
-    'chrome/renderer/extensions/chrome_extensions_renderer_client.*',
     'components/content_settings/core/common/content_settings_types.mojom',
     'components/permissions/request_type.h',
     'content/browser/renderer_host/render_widget_host_view_base.*',

include/cef_api_hash.h

@@ -42,13 +42,13 @@
 // way that may cause binary incompatibility with other builds. The universal
 // hash value will change if any platform is affected whereas the platform hash
 // values will change only if that particular platform is affected.
-#define CEF_API_HASH_UNIVERSAL "9428a74387b371a45469c91f7dbd648b2dc74132"
+#define CEF_API_HASH_UNIVERSAL "316cc23ff49e0d0962090cbfb0a0279ce3dc3c50"
 #if defined(OS_WIN)
-#define CEF_API_HASH_PLATFORM "e76d3804b2419a0bf024e97d6b9e10df53d93dad"
+#define CEF_API_HASH_PLATFORM "66c126d91698670af3835a707a84ce4dbb4a16fa"
 #elif defined(OS_MAC)
-#define CEF_API_HASH_PLATFORM "c88c77c84ecbd81cbf4489c1b1ab4bf0396c26c3"
+#define CEF_API_HASH_PLATFORM "c1d8d20920c3a3e13a6a6efef51b2b775f69d2c7"
 #elif defined(OS_LINUX)
-#define CEF_API_HASH_PLATFORM "84373e28b1ed172ce6a08da2ea33ca787f92d6dc"
+#define CEF_API_HASH_PLATFORM "7ccfa4c608c16a4f8bedc97a2bdf50729784c5ee"
 #endif
 
 #ifdef __cplusplus

include/internal/cef_types.h

@@ -3451,7 +3451,8 @@ typedef enum {
   CEF_CPAIT_PRICE_READ_ANYTHING,
   CEF_CPAIT_PRODUCT_SPECIFICATIONS,
   CEF_CPAIT_LENS_OVERLAY,
-  CEF_CPAIT_MAX_VALUE = CEF_CPAIT_LENS_OVERLAY,
+  CEF_CPAIT_DISCOUNTS,
+  CEF_CPAIT_MAX_VALUE = CEF_CPAIT_DISCOUNTS,
 } cef_chrome_page_action_icon_type_t;
 
 ///

include/internal/cef_types_content_settings.h

@@ -438,12 +438,35 @@ typedef enum {
 
   /// Website setting which is used for UnusedSitePermissionsService to store
   /// auto-revoked notification permissions from abusive sites.
-  REVOKED_ABUSIVE_NOTIFICATION_PERMISSIONS,
+  CEF_CONTENT_SETTING_TYPE_REVOKED_ABUSIVE_NOTIFICATION_PERMISSIONS,
 
   /// Content setting that controls tracking protection status per site.
   /// BLOCK: Protections enabled. This is the default state.
   /// ALLOW: Protections disabled.
-  TRACKING_PROTECTION,
+  CEF_CONTENT_SETTING_TYPE_TRACKING_PROTECTION,
+
+  // With this permission, when the application calls `getDisplayMedia()`, a
+  // system audio track can be returned without showing the display media
+  // selection picker. The application can explicitly specify
+  // `systemAudio: 'exclude'` or `video: true` to still show the display media
+  // selection picker if needed. Please note that the setting only works for
+  // WebUI.
+  CEF_CONTENT_SETTING_TYPE_DISPLAY_MEDIA_SYSTEM_AUDIO,
+
+  // Whether to use the higher-tier v8 optimizers for running JavaScript on the
+  // page.
+  CEF_CONTENT_SETTING_TYPE_JAVASCRIPT_OPTIMIZER,
+
+  // Content Setting for the Storage Access Headers persistent origin trial that
+  // allows origins to opt into the storage access header behavior. Should be
+  // scoped to `REQUESTING_ORIGIN_AND_TOP_SCHEMEFUL_SITE_SCOPE` in order to
+  // correspond to the design of persistent origin trials. See also:
+  // https://github.com/cfredric/storage-access-headers
+  // ALLOW: storage access request headers will be attached to cross-site
+  //        requests, and url requests will look for response headers from
+  //        origins to retry a request or load with storage access.
+  // BLOCK (default): no effect.
+  CEF_CONTENT_SETTING_TYPE_STORAGE_ACCESS_HEADER_ORIGIN_TRIAL,
 } cef_content_setting_types_t;
 
 ///

libcef/browser/browser_host_base.cc

@@ -1275,16 +1275,15 @@ void CefBrowserHostBase::RunSelectFile(
     const ui::SelectFileDialog::FileTypeInfo* file_types,
     int file_type_index,
     const base::FilePath::StringType& default_extension,
-    gfx::NativeWindow owning_window,
-    void* params) {
+    gfx::NativeWindow owning_window) {
   if (!EnsureFileDialogManager()) {
     LOG(ERROR) << "File dialog canceled due to invalid state.";
-    listener->FileSelectionCanceled(params);
+    listener->FileSelectionCanceled();
     return;
   }
   file_dialog_manager_->RunSelectFile(listener, std::move(policy), type, title,
                                       default_path, file_types, file_type_index,
-                                      default_extension, owning_window, params);
+                                      default_extension, owning_window);
 }
 
 void CefBrowserHostBase::SelectFileListenerDestroyed(

libcef/browser/browser_host_base.h

@@ -330,8 +330,7 @@ class CefBrowserHostBase : public CefBrowserHost,
                      const ui::SelectFileDialog::FileTypeInfo* file_types,
                      int file_type_index,
                      const base::FilePath::StringType& default_extension,
-                     gfx::NativeWindow owning_window,
-                     void* params);
+                     gfx::NativeWindow owning_window);
   void SelectFileListenerDestroyed(ui::SelectFileDialog::Listener* listener);
 
   // Called from AlloyBrowserHostImpl::GetJavaScriptDialogManager and

libcef/browser/file_dialog_manager.cc

@@ -203,9 +203,8 @@ class CefFileSelectListener : public content::FileSelectListener {
 class CefSelectFileDialogListener : public ui::SelectFileDialog::Listener {
  public:
   CefSelectFileDialogListener(ui::SelectFileDialog::Listener* listener,
-                              void* params,
                               base::OnceClosure callback)
-      : listener_(listener), params_(params), callback_(std::move(callback)) {}
+      : listener_(listener), callback_(std::move(callback)) {}
 
   CefSelectFileDialogListener(const CefSelectFileDialogListener&) = delete;
   CefSelectFileDialogListener& operator=(const CefSelectFileDialogListener&) =
@@ -220,7 +219,7 @@ class CefSelectFileDialogListener : public ui::SelectFileDialog::Listener {
       // Don't execute the listener.
       Destroy();
     } else {
-      FileSelectionCanceled(params_);
+      FileSelectionCanceled();
     }
   }
 
@@ -229,27 +228,22 @@ class CefSelectFileDialogListener : public ui::SelectFileDialog::Listener {
  private:
   ~CefSelectFileDialogListener() override = default;
 
-  void FileSelected(const ui::SelectedFileInfo& file,
-                    int index,
-                    void* params) override {
-    DCHECK_EQ(params, params_);
+  void FileSelected(const ui::SelectedFileInfo& file, int index) override {
     executing_ = true;
-    listener_.ExtractAsDangling()->FileSelected(file, index, params);
+    listener_.ExtractAsDangling()->FileSelected(file, index);
     Destroy();
   }
 
-  void MultiFilesSelected(const std::vector<ui::SelectedFileInfo>& files,
-                          void* params) override {
-    DCHECK_EQ(params, params_);
+  void MultiFilesSelected(
+      const std::vector<ui::SelectedFileInfo>& files) override {
     executing_ = true;
-    listener_.ExtractAsDangling()->MultiFilesSelected(files, params);
+    listener_.ExtractAsDangling()->MultiFilesSelected(files);
     Destroy();
   }
 
-  void FileSelectionCanceled(void* params) override {
-    DCHECK_EQ(params, params_);
+  void FileSelectionCanceled() override {
     executing_ = true;
-    listener_.ExtractAsDangling()->FileSelectionCanceled(params);
+    listener_.ExtractAsDangling()->FileSelectionCanceled();
     Destroy();
   }
 
@@ -259,7 +253,6 @@ class CefSelectFileDialogListener : public ui::SelectFileDialog::Listener {
   }
 
   raw_ptr<ui::SelectFileDialog::Listener> listener_;
-  const raw_ptr<void> params_;
   base::OnceClosure callback_;
 
   // Used to avoid re-entrancy from Cancel().
@@ -378,18 +371,16 @@ void CefFileDialogManager::RunSelectFile(
     const ui::SelectFileDialog::FileTypeInfo* file_types,
     int file_type_index,
     const base::FilePath::StringType& default_extension,
-    gfx::NativeWindow owning_window,
-    void* params) {
+    gfx::NativeWindow owning_window) {
   CEF_REQUIRE_UIT();
 
   active_listeners_.insert(listener);
 
   auto chooser_params =
       SelectFileToFileChooserParams(type, title, default_path, file_types);
-  auto callback =
-      base::BindOnce(&CefFileDialogManager::SelectFileDoneByDelegateCallback,
-                     weak_ptr_factory_.GetWeakPtr(),
-                     base::UnsafeDangling(listener), base::Unretained(params));
+  auto callback = base::BindOnce(
+      &CefFileDialogManager::SelectFileDoneByDelegateCallback,
+      weak_ptr_factory_.GetWeakPtr(), base::UnsafeDangling(listener));
   callback = MaybeRunDelegate(chooser_params, file_types->extensions,
                               file_types->extension_description_overrides,
                               std::move(callback));
@@ -423,7 +414,7 @@ void CefFileDialogManager::RunSelectFile(
 
   // This object will delete itself.
   dialog_listener_ = new CefSelectFileDialogListener(
-      listener, params,
+      listener,
       base::BindOnce(&CefFileDialogManager::SelectFileDoneByListenerCallback,
                      weak_ptr_factory_.GetWeakPtr(),
                      base::UnsafeDangling(listener),
@@ -442,7 +433,7 @@ void CefFileDialogManager::RunSelectFile(
   }
 
   dialog_->SelectFile(type, title, default_path, file_types, file_type_index,
-                      default_extension, owning_window, params);
+                      default_extension, owning_window);
 }
 
 void CefFileDialogManager::SelectFileListenerDestroyed(
@@ -549,7 +540,6 @@ CefFileDialogManager::MaybeRunDelegate(
 
 void CefFileDialogManager::SelectFileDoneByDelegateCallback(
     MayBeDangling<ui::SelectFileDialog::Listener> listener,
-    void* params,
     const std::vector<base::FilePath>& paths) {
   CEF_REQUIRE_UIT();
 
@@ -562,12 +552,11 @@ void CefFileDialogManager::SelectFileDoneByDelegateCallback(
   active_listeners_.erase(listener.get());
 
   if (paths.empty()) {
-    listener->FileSelectionCanceled(params);
+    listener->FileSelectionCanceled();
   } else if (paths.size() == 1) {
-    listener->FileSelected(ui::SelectedFileInfo(paths[0]), /*index=*/0, params);
+    listener->FileSelected(ui::SelectedFileInfo(paths[0]), /*index=*/0);
   } else {
-    listener->MultiFilesSelected(ui::FilePathListToSelectedFileInfoList(paths),
-                                 params);
+    listener->MultiFilesSelected(ui::FilePathListToSelectedFileInfoList(paths));
   }
   // |listener| is likely deleted at this point.
 }

libcef/browser/file_dialog_manager.h

@@ -66,8 +66,7 @@ class CefFileDialogManager {
                      const ui::SelectFileDialog::FileTypeInfo* file_types,
                      int file_type_index,
                      const base::FilePath::StringType& default_extension,
-                     gfx::NativeWindow owning_window,
-                     void* params);
+                     gfx::NativeWindow owning_window);
 
   // Must be called when the |listener| passed to RunSelectFile is destroyed.
   void SelectFileListenerDestroyed(ui::SelectFileDialog::Listener* listener);
@@ -83,7 +82,6 @@ class CefFileDialogManager {
 
   void SelectFileDoneByDelegateCallback(
       MayBeDangling<ui::SelectFileDialog::Listener> listener,
-      void* params,
       const std::vector<base::FilePath>& paths);
   void SelectFileDoneByListenerCallback(
       MayBeDangling<ui::SelectFileDialog::Listener> listener,