Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status #3

Open
nsaunders opened this issue Mar 1, 2023 · 4 comments
Open

Status #3

nsaunders opened this issue Mar 1, 2023 · 4 comments

Comments

@nsaunders
Copy link
Collaborator

Hi there @chrisdotcode. I noticed that you haven't had a chance to update this library in quite a long time. If you've lost interest, I was wondering whether you might consider letting me take over maintainership? Thanks in advance for your consideration.

@chrisdotcode
Copy link
Owner

chrisdotcode commented Mar 3, 2023

Hey, @nsaunders, I'm honored that somebody would want to continue maintenanceship of this project!

The code as you can tell is quite old - and while I don't think it was ever bad or hacky, it still is old, and so perhaps it needs a rework with some newer PureScript idioms and additions that have been added since added to the language. (And as of now, I don't even think it builds properly on current PS.)

If you'd like to make a MR or two ensuring that the code builds with newer PS versions, and probably also adding in #2, then I think that that'll be a good step to start distributing maintenanceship. What do you think?

@nsaunders
Copy link
Collaborator Author

Hi @chrisdotcode, thanks for your consideration. As you'll see in #4, I have started by updating the library to work with the latest compiler version.

To add a bit more context, I have no concerns regarding code quality; and, actually, most of the required changes were due to upstream dependency changes. My main goals are to reintroduce this into the ecosystem and spread out the maintenance burden a bit so that we can ensure it continues to work with the latest dependency and compiler versions.

@chrisdotcode
Copy link
Owner

Thanks, @nsaunders! Give me just a few more days to get back to you.

@chrisdotcode chrisdotcode reopened this Mar 8, 2023
@chrisdotcode
Copy link
Owner

chrisdotcode commented May 30, 2023

Hey @nsaunders, thanks for your patience! Turns out I was experiencing some time dilation: that "few more days" was longer than I had intended...

In any case, I've given you push access to make changes you deem necessary to push the project forward. Thanks again for the desire to help me maintain the lib, and while I can't contribute much in the next month or so, feel free to start new discussions and the like 🙂

If/when you're ready to push a new package to pursuit, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants