Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New S3 methods for fmsm objects #131

Open
mattwarkentin opened this issue Jun 1, 2022 · 2 comments
Open

New S3 methods for fmsm objects #131

mattwarkentin opened this issue Jun 1, 2022 · 2 comments

Comments

@mattwarkentin
Copy link
Contributor

mattwarkentin commented Jun 1, 2022

Hi @chjackson,

Would you be open to a pull request for a new predict.fmsm method for the predict S3 generic? I would generally match the argument signature to the predict.flexsurvreg method, where applicable.

The predict.fmsm method would wrap pmatrix.fs/pmatrix.simfs and totlos.fs/totlos.simfs. Thus, the prediction types could be: 'prob' and 'totlos'.

I would also be interested in adding a tidy.fmsm method that ostensibly does purrr::map_dfr(fmsm_obj, tidy, .id = 'trans').

What are your thoughts?

@chjackson
Copy link
Owner

Both of those sound good - thanks!

@kkmann
Copy link
Contributor

kkmann commented Feb 8, 2023

@mattwarkentin would be interested in those too - you would not happen to have a PR lying around ;) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants