When activating an ABP device, fNwkSIntKey and sNwkSIntKey are both required and nullable

[philippe-tensio]

Description

Using the POST -> /api/devices/DEVEUI/activate, when sending a request that doesn't have a fNwkSIntKey and sNwkSIntKey, we still receive a HTTP 200, however the device will not activate. Even more confusing, is that both keys are displayed as 00000[...] in the Chirpstack UI, giving the impression that both keys are set properly.

If a fNwkSIntKey and sNwkSIntKey are provided, a HTTP 200 response is received and device becomes activated.

Would it be possible to for the request to return a HTTP 400, if we are missing fNwkSIntKey and sNwkSIntKey?

Repro steps

Using Chirpstack-Docker with Chirpstack 4.12 and Chirpstack-Rest-Api 4.12 and using an ABP Device, activate the device using the API (the issue will not occur if done using the UI).

Related issues

This forum post from 2023 helped show me the problem.