Skip to content

Commit 6b75802

Browse files
committed
Update chirpstack-api package and set FDev.
Note that the BitRate to Datarate rename is backwards compatible when using the Protobuf marshaler (as fields are numbered, not named over the wire).
1 parent 06ea30d commit 6b75802

File tree

10 files changed

+16
-16
lines changed

10 files changed

+16
-16
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/brocaar/chirpstack-gateway-bridge
33
go 1.13
44

55
require (
6-
github.com/brocaar/chirpstack-api/go/v3 v3.0.1
6+
github.com/brocaar/chirpstack-api/go/v3 v3.0.7
77
github.com/brocaar/lorawan v0.0.0-20190814113539-8eb2a8d6da09
88
github.com/dgrijalva/jwt-go v3.2.0+incompatible
99
github.com/eclipse/paho.mqtt.golang v1.2.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
2424
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
2525
github.com/blakesmith/ar v0.0.0-20150311145944-8bd4349a67f2 h1:oMCHnXa6CCCafdPDbMh/lWRhRByN0VFLvv+g+ayx1SI=
2626
github.com/blakesmith/ar v0.0.0-20150311145944-8bd4349a67f2/go.mod h1:PkYb9DJNAwrSvRx5DYA+gUcOIgTGVMNkfSCbZM8cWpI=
27-
github.com/brocaar/chirpstack-api/go/v3 v3.0.1 h1:FEz8I2DRwRrDt2Am7lntUA5T29ZjRcufs1/ovCHFHi4=
28-
github.com/brocaar/chirpstack-api/go/v3 v3.0.1/go.mod h1:sCxojNSPGdUUIImu2OBwP/GRa6xrCEN7H8eP2AYr178=
27+
github.com/brocaar/chirpstack-api/go/v3 v3.0.7 h1:cE6f9cAH9SF+RHHB/QfI7acNQqeWmhdiPIrkm1Q1zQo=
28+
github.com/brocaar/chirpstack-api/go/v3 v3.0.7/go.mod h1:sCxojNSPGdUUIImu2OBwP/GRa6xrCEN7H8eP2AYr178=
2929
github.com/brocaar/lorawan v0.0.0-20190814113539-8eb2a8d6da09 h1:hV+axbeTsoTCa1tEkXzDjucdg1GPSX9j1fn95saTKBo=
3030
github.com/brocaar/lorawan v0.0.0-20190814113539-8eb2a8d6da09/go.mod h1:Fm+51pxK6mZoAQjIaWJqPmnRuXecozsM5Mf9c+kr/ko=
3131
github.com/caarlos0/ctrlc v1.0.0 h1:2DtF8GSIcajgffDFJzyG15vO+1PuBWOMUdFut7NnXhw=

internal/backend/basicstation/structs/downlink_message.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@ func DownlinkFrameFromProto(loraBand band.Band, pb gw.DownlinkFrame) (DownlinkFr
8686
}
8787
dr, err = loraBand.GetDataRateIndex(false, band.DataRate{
8888
Modulation: band.FSKModulation,
89-
Bandwidth: int(modInfo.Bandwidth),
90-
BitRate: int(modInfo.Bitrate),
89+
BitRate: int(modInfo.Datarate),
9190
})
9291
if err != nil {
9392
return out, errors.Wrap(err, "get data-rate index error")

internal/backend/basicstation/structs/downlink_message_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func TestDownlinkFrameFromProto(t *testing.T) {
7979
Modulation: common.Modulation_FSK,
8080
ModulationInfo: &gw.DownlinkTXInfo_FskModulationInfo{
8181
FskModulationInfo: &gw.FSKModulationInfo{
82-
Bitrate: 50000,
82+
Datarate: 50000,
8383
},
8484
},
8585
Timing: gw.DownlinkTiming_DELAY,

internal/backend/basicstation/structs/radio_meta_data.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,7 @@ func SetRadioMetaDataToProto(loraBand band.Band, gatewayID lorawan.EUI64, rmd Ra
5757
pb.TxInfo.Modulation = common.Modulation_FSK
5858
pb.TxInfo.ModulationInfo = &gw.UplinkTXInfo_FskModulationInfo{
5959
FskModulationInfo: &gw.FSKModulationInfo{
60-
Bandwidth: uint32(dr.Bandwidth),
61-
Bitrate: uint32(dr.BitRate),
60+
Datarate: uint32(dr.BitRate),
6261
},
6362
}
6463
}

internal/backend/basicstation/structs/radio_meta_data_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func TestSetRadioMetaDataToProto(t *testing.T) {
7575
Modulation: common.Modulation_FSK,
7676
ModulationInfo: &gw.UplinkTXInfo_FskModulationInfo{
7777
FskModulationInfo: &gw.FSKModulationInfo{
78-
Bitrate: 50000,
78+
Datarate: 50000,
7979
},
8080
},
8181
},

internal/backend/semtechudp/backend_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ import (
1717
"github.com/stretchr/testify/require"
1818
"github.com/stretchr/testify/suite"
1919

20-
"github.com/brocaar/chirpstack-gateway-bridge/internal/backend/semtechudp/packets"
21-
"github.com/brocaar/chirpstack-gateway-bridge/internal/config"
2220
"github.com/brocaar/chirpstack-api/go/v3/common"
2321
"github.com/brocaar/chirpstack-api/go/v3/gw"
22+
"github.com/brocaar/chirpstack-gateway-bridge/internal/backend/semtechudp/packets"
23+
"github.com/brocaar/chirpstack-gateway-bridge/internal/config"
2424
"github.com/brocaar/lorawan"
2525
)
2626

@@ -467,7 +467,8 @@ func (ts *BackendTestSuite) TestSendDownlinkFrame() {
467467
Modulation: common.Modulation_FSK,
468468
ModulationInfo: &gw.DownlinkTXInfo_FskModulationInfo{
469469
FskModulationInfo: &gw.FSKModulationInfo{
470-
Bitrate: 50000,
470+
Datarate: 50000,
471+
FrequencyDeviation: 25000,
471472
},
472473
},
473474
Board: 1,

internal/backend/semtechudp/packets/pull_resp.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ func GetPullRespPacket(protoVersion uint8, randomToken uint16, frame gw.Downlink
114114
if modInfo == nil {
115115
return packet, errors.New("gateway: fsk_modulation_info must not be nil")
116116
}
117-
packet.Payload.TXPK.DatR.FSK = modInfo.Bitrate
118-
packet.Payload.TXPK.FDev = uint16(modInfo.Bitrate / 2) // TODO: is this correct?!
117+
packet.Payload.TXPK.DatR.FSK = modInfo.Datarate
118+
packet.Payload.TXPK.FDev = uint16(modInfo.FrequencyDeviation)
119119
}
120120

121121
switch frame.TxInfo.Timing {

internal/backend/semtechudp/packets/pull_resp_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@ func TestGetPullRespPacket(t *testing.T) {
115115
Modulation: common.Modulation_FSK,
116116
ModulationInfo: &gw.DownlinkTXInfo_FskModulationInfo{
117117
FskModulationInfo: &gw.FSKModulationInfo{
118-
Bitrate: 50000,
118+
Datarate: 50000,
119+
FrequencyDeviation: 25000,
119120
},
120121
},
121122
Board: 1,

internal/backend/semtechudp/packets/push_data.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ func getUplinkFrame(gatewayID []byte, rxpk RXPK, FakeRxInfoTime bool) (gw.Uplink
226226

227227
frame.TxInfo.ModulationInfo = &gw.UplinkTXInfo_FskModulationInfo{
228228
FskModulationInfo: &gw.FSKModulationInfo{
229-
Bitrate: uint32(rxpk.DatR.FSK),
229+
Datarate: uint32(rxpk.DatR.FSK),
230230
},
231231
}
232232
}

0 commit comments

Comments
 (0)