Skip to content

Commit b63f6cc

Browse files
codemashercodemasher
committed
:octocat: fixed "optional parameter before mandatory"
1 parent c02abdb commit b63f6cc

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

‎src/Dialects/Dialect.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public function quote(string $str):string;
3333
*
3434
* @return array
3535
*/
36-
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby, array $orderby):array;
36+
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby = null, array $orderby = null):array;
3737

3838
/**
3939
* @param array $expressions
@@ -112,7 +112,7 @@ public function createDatabase(string $dbname, bool $ifNotExists = null, string
112112
*
113113
* @return array
114114
*/
115-
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array;
115+
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists = null, bool $temp = null, string $dir = null):array;
116116

117117
/**
118118
* @param string $dbname

‎src/Dialects/Firebird.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class Firebird extends DialectAbstract{
1919
protected $quotes = ['"', '"'];
2020

2121
/** @inheritdoc */
22-
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby, array $orderby):array{
22+
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby = null, array $orderby = null):array{
2323
$sql = ['SELECT'];
2424

2525
if($limit !== null){
@@ -52,7 +52,7 @@ public function select(array $cols, array $from, string $where = null, $limit =
5252
}
5353

5454
/** @inheritdoc */
55-
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array{
55+
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists = null, bool $temp = null, string $dir = null):array{
5656
$sql = [$ifNotExists ? 'RECREATE' : 'CREATE']; // nasty
5757

5858
if($temp){

‎src/Dialects/MSSQL.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class MSSQL extends DialectAbstract{
1717
protected $quotes = ['[', ']'];
1818

1919
/** @inheritdoc */
20-
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby, array $orderby):array{
20+
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby = null, array $orderby = null):array{
2121
$sql = ['SELECT'];
2222

2323
if($distinct){
@@ -68,7 +68,7 @@ public function createDatabase(string $dbname, bool $ifNotExists = null, string
6868
}
6969

7070
/** @inheritdoc */
71-
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array{
71+
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists = null, bool $temp = null, string $dir = null):array{
7272
$sql = ['CREATE TABLE'];
7373
$sql[] = $this->quote($table);
7474

‎src/Dialects/MySQL.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function createDatabase(string $dbname, bool $ifNotExists = null, string
7070
}
7171

7272
/** @inheritdoc */
73-
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array {
73+
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists = null, bool $temp = null, string $dir = null):array {
7474
$sql = ['CREATE'];
7575

7676
if($temp){

‎src/Dialects/Postgres.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class Postgres extends DialectAbstract{
1919
protected $quotes = ['"', '"'];
2020

2121
/** @inheritdoc */
22-
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby, array $orderby):array{
22+
public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby = null, array $orderby = null):array{
2323
$sql = ['SELECT'];
2424

2525
if($distinct){
@@ -203,7 +203,7 @@ public function fieldspec(string $name, string $type, $length = null, string $at
203203
}
204204

205205
/** @inheritdoc */
206-
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array{
206+
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists = null, bool $temp = null, string $dir = null):array{
207207
$sql[] = 'CREATE';
208208

209209
if($temp){

‎src/Dialects/SQLite.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function fieldspec(string $name, string $type, $length = null, string $at
6767
}
6868

6969
/** @inheritdoc */
70-
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array{
70+
public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists = null, bool $temp = null, string $dir = null):array{
7171
$sql = ['CREATE'];
7272

7373
if($temp){

0 commit comments

Comments
 (0)