Skip to content

Turn the loading bar off also disables the spinner [bug] #290

Open
@Anubiso

Description

@Anubiso

Hello i'm using the latest version of angular-loading-bar (v0.9.0).

In your documentation you write:

Like the spinner configuration above, the loading bar can also be turned off for cases where you only want the spinner

but if you turn off the loading bar it also turns off the spinner. Why? Because it gets appended to the loadingBarContainer which doesn't get added to the DOM if includeBar is false.

        if (includeBar) {
          $animate.enter(loadingBarContainer, $parent, $after);
        }

        if (includeSpinner) {
          $animate.enter(spinner, $parent, loadingBarContainer);
        }

I wrote a quick and dirty fix:

       var appendSpinnerTo = $after;
        if (includeBar) {
          $animate.enter(loadingBarContainer, $parent, $after);
          appendSpinnerTo = loadingBarContainer;
        }

        if (includeSpinner) {
          $animate.enter(spinner, $parent, appendSpinnerTo);
        }

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions