fix: runs in strict mode aka deno v0.34.0

Author: chiefbiiko

.github/workflows/cloud_ci.yml

@@ -17,9 +17,9 @@ jobs:
       TABLE_NAME: testing_table
     steps:
       - name: clone repo
-        uses: actions/checkout@v1.0.0
+        uses: actions/checkout@v2.0.0
       - name: install deno
-        uses: denolib/setup-deno@v1.1.0
+        uses: denolib/setup-deno@v1.2.0
       - name: configure aws credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:

.github/workflows/local_ci.yml

@@ -10,19 +10,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: clone repo
-        uses: actions/checkout@v1.0.0
+        uses: actions/checkout@v2.0.0
       - name: install deno
-        uses: denolib/setup-deno@v1.1.0
+        uses: denolib/setup-deno@v1.2.0
       - name: run tests
         run: deno run --allow-env ./test/signv4.ts
   test_local:
     name: test dynamodb local
     runs-on: ubuntu-latest
     steps:
       - name: clone repo
-        uses: actions/checkout@v1.0.0
+        uses: actions/checkout@v2.0.0
       - name: install deno
-        uses: denolib/setup-deno@v1.1.0
+        uses: denolib/setup-deno@v1.2.0
       - name: start a local dynamodb
         run: curl -fsSL https://denopkg.com/chiefbiiko/[email protected]/start_db.sh | bash
       - name: sleep 2 allow db startup

.gitignore

@@ -1,2 +1,2 @@
-dynamodb_local_latest.zip
-dynamodb_local_latest
+dynamodb_local_latest*
+shared-local-instance.db*

api/api.ts

@@ -7,10 +7,14 @@ import {
   property /*, string as stringUtil*/
 } from "../util.ts";
 
+// NOTE: 2 run in ts strict-mode (bypassing TS7009)
+const _Collection: any = Collection
+const _Operation: any = Operation
+
 // var Paginator = require('./paginator');
 // var ResourceWaiter = require('./resource_waiter');
 
-export function Api(api: Doc = {}, options: Doc = {}) {
+export function Api(this: any, api: Doc = {}, options: Doc = {}) {
   const self: any = this;
   // api = api || {};
   // options = options || {};
@@ -38,7 +42,7 @@ export function Api(api: Doc = {}, options: Doc = {}) {
       api.metadata.serviceAbbreviation || api.metadata.serviceFullName;
 
     if (!name) {
-      return null;
+      return "";
     }
 
     name = name.replace(/^Amazon|AWS\s*|\(.*|\s+|\W+/g, "");
@@ -59,11 +63,11 @@ export function Api(api: Doc = {}, options: Doc = {}) {
   property(
     this,
     "operations",
-    new Collection(
+    new _Collection(
       api.operations,
       options,
       function(name: string, operation: Doc): any {
-        return new Operation(name, operation, options);
+        return new _Operation(name, operation, options);
       } /*, stringUtil.lowerFirst*/,
       addEndpointOperation
     )
@@ -72,7 +76,7 @@ export function Api(api: Doc = {}, options: Doc = {}) {
   property(
     this,
     "shapes",
-    new Collection(api.shapes, options, function(
+    new _Collection(api.shapes, options, function(
       name: string,
       shape: Doc
     ): any {

api/collection.ts

@@ -3,6 +3,7 @@
 import { Doc, memoizedProperty, noop } from "../util.ts";
 
 function memoize(
+  this: any,
   name: string,
   value: any,
   factory: (
@@ -16,6 +17,7 @@ function memoize(
 }
 
 export function Collection(
+  this: any, 
   iterable: any,
   options: Doc,
   factory: (

api/mod.ts

@@ -1,7 +1,8 @@
-import { Doc } from "../util.ts";
 import { Api } from "./api.ts";
 
-const spec: Doc = JSON.parse(`
+const _Api: any = Api;
+
+export const API: any = new _Api(JSON.parse(`
 {
   "version": "2.0",
   "metadata": {
@@ -2228,6 +2229,4 @@ const spec: Doc = JSON.parse(`
     }
   }
 }  
-`);
-
-export const API: any = new Api(spec);
+`));

api/operation.ts

@@ -6,7 +6,7 @@ import { Shape } from "./shape.ts";
 import { Doc, memoizedProperty, property } from "../util.ts";
 // import { Doc} from "../types.ts"
 
-export function Operation(name: string, operation: Doc, options: Doc = {}) {
+export function Operation(this: any, name: string, operation: Doc, options: Doc = {}) {
   const self: any = this;
   // options = options || {};
 
@@ -47,7 +47,7 @@ export function Operation(name: string, operation: Doc, options: Doc = {}) {
 
   memoizedProperty(this, "errors", function(): any[] {
     if (!operation.errors) {
-      return null;
+      return [];
     }
 
     return operation.errors.map((error: any): any =>
@@ -83,8 +83,8 @@ export function Operation(name: string, operation: Doc, options: Doc = {}) {
     }
 
     return Object.entries(self.input.members)
-      .filter(([_, value]: [string, Doc]): boolean => value.isIdempotent)
-      .map(([key, _]: [string, Doc]): string => key);
+      .filter(([_, value]: [string, any]): boolean => value.isIdempotent)
+      .map(([key, _]: [string, any]): string => key);
 
     // for (const name in members) {
     //   if (!members.hasOwnProperty(name)) {