Skip to content

Commit 7c4c044

Browse files
author
Christian Mötzing
committed
Fix codacy issues
1 parent 718cdf7 commit 7c4c044

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

src/main/java/com/tagtraum/perf/gcviewer/imp/DataReaderIBM_J9_R28.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,15 @@ public GCModel read() throws IOException {
7777
break;
7878
case SYS_START:
7979
assert eventNameStart == null : "eventNameStart was expected to be null, but was " + eventNameStart;
80-
eventNameStart = handleSysStart(eventReader, startElement);
80+
eventNameStart = handleSysStart(startElement);
8181
break;
8282
case AF_START:
8383
assert eventNameStart == null : "eventNameStart was expected to be null, but was " + eventNameStart;
84-
eventNameStart = handleAfStart(eventReader, startElement);
84+
eventNameStart = handleAfStart();
8585
break;
8686
case CONCURRENT_COLLECTION_START:
8787
assert eventNameStart == null : "eventNameStart was expected to be null, but was " + eventNameStart;
88-
eventNameStart = handleConcurrentCollectionStart(eventReader, startElement);
88+
eventNameStart = handleConcurrentCollectionStart();
8989
break;
9090
case GC_START:
9191
handleGcStart(eventReader, startElement, currentGcEvent, eventNameStart);
@@ -176,16 +176,16 @@ private void handleExclusiveEnd(StartElement startElement, GCEvent event) {
176176
event.setPause(NumberParser.parseDouble(getAttributeValue(startElement, "durationms")) / 1000);
177177
}
178178

179-
private String handleSysStart(XMLEventReader eventReader, StartElement startElement) throws XMLStreamException {
179+
private String handleSysStart(StartElement startElement) {
180180
String reason = getAttributeValue(startElement, "reason");
181181
return "sys " + (reason != null ? reason + " " : "");
182182
}
183183

184-
private String handleAfStart(XMLEventReader eventReader, StartElement startElement) throws XMLStreamException {
184+
private String handleAfStart() {
185185
return "af ";
186186
}
187187

188-
private String handleConcurrentCollectionStart(XMLEventReader eventReader, StartElement startElement) {
188+
private String handleConcurrentCollectionStart() {
189189
return "concurrent-collection-start ";
190190
}
191191

src/test/java/com/tagtraum/perf/gcviewer/imp/TestDataReaderIBM_J9_R27.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.tagtraum.perf.gcviewer.imp;
22

33
import static com.tagtraum.perf.gcviewer.UnittestHelper.toKiloBytes;
4-
import static com.tagtraum.perf.gcviewer.imp.TestDataReaderIBM_J9_R28.*;
4+
import static com.tagtraum.perf.gcviewer.imp.TestDataReaderIBM_J9_R28.verifyTimestamp;
55
import static org.hamcrest.Matchers.is;
66
import static org.hamcrest.Matchers.startsWith;
77
import static org.hamcrest.number.IsCloseTo.closeTo;

src/test/java/com/tagtraum/perf/gcviewer/imp/TestDataReaderIBM_J9_R28.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,12 @@
1515

1616
import com.tagtraum.perf.gcviewer.UnittestHelper;
1717
import com.tagtraum.perf.gcviewer.UnittestHelper.FOLDER;
18-
import com.tagtraum.perf.gcviewer.model.*;
18+
import com.tagtraum.perf.gcviewer.model.AbstractGCEvent;
19+
import com.tagtraum.perf.gcviewer.model.GCEvent;
20+
import com.tagtraum.perf.gcviewer.model.GCModel;
21+
import com.tagtraum.perf.gcviewer.model.GcResourceFile;
22+
import com.tagtraum.perf.gcviewer.model.GCResource;
23+
1924
import org.junit.Test;
2025

2126
/**

0 commit comments

Comments
 (0)