Skip to content

Commit 77c65d0

Browse files
committed
Name artifact chart.umd.js, fixes #11455
1 parent e74ee7b commit 77c65d0

File tree

7 files changed

+25
-10
lines changed

7 files changed

+25
-10
lines changed

.github/ISSUE_TEMPLATE/bug.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ body:
4545
For typescript issues you can make use of [this TS Playground](https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYQBYENZwL5wGZQQhwDkAxhrAHQBWAziQNwCwAUGwG6ZxkwAecALxwAJhDIBXEAFMAdjCoBzaTACiAG2kz5AIQCeASREAKAEQg9aTDFMBKOOjpwAEgBUAsgBlk6WVzoaWnIwLKxcUHAWVljCstIA7iiUMMa8fAA0iGxwOXAwemDSAFyk6sBxJOnZuSLoMOglCNW5ueroAEbS6nQlANqmAErSIqaZpjrqEtKjcKYAml3qEPEzpgDiUNJyqwAKElBgmqsA8lC+yqYAulWsLS219XQqPXC9Tbd3n22d6iUkAMRwCB4OAANQgMGkDBun0+DwarwAjAAmTKIgCcmQAzJkAKyZVFwLHXZp3bCXUnYGG5CBgGDACCyF7vT50MjoTTM0ktPiNbl3fk5KmCuB6PkfWFwEXYfkyiU4NjYWyMIA) to make a reproducible sample.
4646
4747
If filing a bug against `master`, you may reference the latest code via
48-
https://www.chartjs.org/dist/master/chart.umd.js (changing the filename to
48+
https://www.chartjs.org/dist/master/chart.umd.min.js (changing the filename to
4949
point at the file you need as appropriate). Do not rely on these files for
5050
production purposes as they may be removed at any time.
5151
validations:

docs/developers/contributing.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,6 @@ Guidelines for reporting bugs:
7474

7575
- Check the issue search to see if it has already been reported
7676
- Isolate the problem to a simple test case
77-
- Please include a demonstration of the bug on a website such as [JS Bin](https://jsbin.com/), [JS Fiddle](https://jsfiddle.net/), or [Codepen](https://codepen.io/pen/). ([Template](https://codepen.io/pen?template=wvezeOq)). If filing a bug against `master`, you may reference the latest code via <https://www.chartjs.org/dist/master/chart.umd.js> (changing the filename to point at the file you need as appropriate). Do not rely on these files for production purposes as they may be removed at any time.
77+
- Please include a demonstration of the bug on a website such as [JS Bin](https://jsbin.com/), [JS Fiddle](https://jsfiddle.net/), or [Codepen](https://codepen.io/pen/). ([Template](https://codepen.io/pen?template=wvezeOq)). If filing a bug against `master`, you may reference the latest code via <https://www.chartjs.org/dist/master/chart.umd.min.js> (changing the filename to point at the file you need as appropriate). Do not rely on these files for production purposes as they may be removed at any time.
7878

7979
Please provide any additional details associated with the bug, if it's browser or screen density specific, or only happens with a certain configuration or data.

docs/getting-started/integration.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ If you're using a front-end framework (e.g., React, Angular, or Vue), please see
77
## Script Tag
88

99
```html
10-
<script src="path/to/chartjs/dist/chart.umd.js"></script>
10+
<script src="path/to/chartjs/dist/chart.umd.min.js"></script>
1111
<script>
1212
const myChart = new Chart(ctx, {...});
1313
</script>
@@ -122,10 +122,10 @@ const { Chart } = await import('chart.js');
122122

123123
## RequireJS
124124

125-
**Important:** RequireJS can load only [AMD modules](https://requirejs.org/docs/whyamd.html), so be sure to require one of the UMD builds instead (i.e. `dist/chart.umd.js`).
125+
**Important:** RequireJS can load only [AMD modules](https://requirejs.org/docs/whyamd.html), so be sure to require one of the UMD builds instead (i.e. `dist/chart.umd.min.js`).
126126

127127
```javascript
128-
require(['path/to/chartjs/dist/chart.umd.js'], function(Chart){
128+
require(['path/to/chartjs/dist/chart.umd.min.js'], function(Chart){
129129
const myChart = new Chart(ctx, {...});
130130
});
131131
```

docs/migration/v4-migration.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ A number of changes were made to the configuration options passed to the `Chart`
3030
* Time and timeseries scales use `ticks.stepSize` instead of `time.stepSize`, which has been removed.
3131
* `maxTickslimit` wont be used for the ticks in `autoSkip` if the determined max ticks is less then the `maxTicksLimit`.
3232
* `dist/chart.js` has been removed.
33-
* `dist/chart.min.js` has been renamed to `dist/chart.umd.js`.
33+
* `dist/chart.min.js` has been renamed to `dist/chart.umd.min.js`.
3434
* `dist/chart.esm.js` has been renamed to `dist/chart.js`.
3535

3636
#### Type changes

package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@
88
"sideEffects": [
99
"./auto/auto.js",
1010
"./auto/auto.cjs",
11+
"./dist/chart.umd.min.js",
1112
"./dist/chart.umd.js"
1213
],
13-
"jsdelivr": "./dist/chart.umd.js",
14-
"unpkg": "./dist/chart.umd.js",
14+
"jsdelivr": "./dist/chart.umd.min.js",
15+
"unpkg": "./dist/chart.umd.min.js",
1516
"main": "./dist/chart.cjs",
1617
"module": "./dist/chart.js",
1718
"exports": {

rollup.config.js

+15-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,21 @@ const plugins = (minify) =>
4545

4646
export default [
4747
// UMD build
48-
// dist/chart.umd.js
48+
// dist/chart.umd.min.js
49+
{
50+
input: 'src/index.umd.ts',
51+
plugins: plugins(true),
52+
output: {
53+
name: 'Chart',
54+
file: 'dist/chart.umd.min.js',
55+
format: 'umd',
56+
indent: false,
57+
sourcemap: true,
58+
},
59+
},
60+
61+
// UMD build
62+
// dist/chart.umd.js (old filename)
4963
{
5064
input: 'src/index.umd.ts',
5165
plugins: plugins(true),

test/BasicChartWebWorker.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// Sends messages with data of types: { type: 'success' } | { type: 'error', errorMessage: string }
77

88
// eslint-disable-next-line no-undef
9-
importScripts('../src/chart.umd.js');
9+
importScripts('../src/chart.umd.min.js');
1010

1111
onmessage = function(event) {
1212
try {

0 commit comments

Comments
 (0)