-
Notifications
You must be signed in to change notification settings - Fork 4
Generate initial set of auto-inserted links #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
|
@DanilaFe : Q: How hard would it be to make the links to the docs be relative rather than absolute? Wondering from the perspectives of:
|
|
It should be pretty easy. Right now, I have logic that hardcodes the |
|
I'm pretty sure some of the desktop-based link checkers I've used will make sure that an |
|
Oh wait, I'm realizing you're probably talking about the link checking you've set up, not a more general link-checking script…? |
|
Yes, I'm referring to the link checking script I'm checking in with this PR (and which would run with CI after this PR merges) |
This PR builds on https://github.com/chapel-lang/chapel-blog/pull/281 to insert documentation links. In this PR, I do the following things:
check_doc_links.py, which validates the links in the cache. In particular, it loads the pages and tries to find the corresponding fragment of the page.insert_links.pyto avoid emitting links that go nowhere (caught bycheck_doc_links.py). In some cases this is due to custom wrangling that we do.insert_links.pyto generate an initial set of links-to-insert.To address some of @bradcray's concerns, this PR also adds a CI check to verify that links in the link cache are valid.