128X-MAC: properly absorb all concatenated tags into the first lane #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FinalizeMac` function concatenates the tags from all AEGIS instances and absorbs them into the first state, following the behavior of AEGIS-128L. However, the `Update` function referenced here belongs to AEGIS-128X. When the degree is greater than 1, bytes [16..32] correspond to the second AEGIS instance (or, in implementations, the second half of a 256-bit register), rather than the first instance. Adjust the padding to ensure all bytes are correctly loaded into the first instance.
|
Known implementations have been updated to reflect this, but we should publish a new revision quickly. |
samuel-lucas6
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FinalizeMacfunction concatenates the tags from all AEGIS instances and absorbs them into the first state, following the behavior of AEGIS-128L.However, the
Updatefunction referenced here belongs to AEGIS-128X.When the degree is greater than 1, bytes [16..32] correspond to the second AEGIS instance (or, in implementations, the second half of a 256-bit register), rather than the first instance.
Adjust the padding to ensure all bytes are correctly loaded into the first instance.