Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage section on readme uses old property #3

Open
daveobriencouk opened this issue Jan 27, 2019 · 1 comment
Open

Usage section on readme uses old property #3

daveobriencouk opened this issue Jan 27, 2019 · 1 comment

Comments

@daveobriencouk
Copy link

First off - this is an awesome module, thank you!

I've noticed that one of the property values on the readme is out of date.

The usage section refers to a baseLineHeight in the options object passed to the styledComponentsRhythm - I think it should be defaultLineHeight. It's a small point but got me lost for 20mins.

Happy to create a PR if it helps.
@ilia-luk
Copy link

same here, really nice work, took me a few min to spot this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveobriencouk @ilia-luk