Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SSL support on nginx configuration #3

Open
ManofWax opened this issue Feb 23, 2023 · 4 comments
Open

Adding SSL support on nginx configuration #3

ManofWax opened this issue Feb 23, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@ManofWax
Copy link
Contributor

Nginx configuration only supports HTTP right now.

We should support HTTPS, to do so we should change the nginx config and write a guide to let users deploy their certificate on nginx.

I know this tools https://github.com/FiloSottile/mkcert that should simplify certificate creation, but I'm open to other suggestions. The procedure should be easy to follow and detailed on buffalogs readme.

@ManofWax ManofWax added the good first issue Good for newcomers label Feb 23, 2023
@Hverma1206
Copy link

We can update the Nginx configuration to support HTTPS. Instead of using mkcert, I plan to implement this using AWS services, likely AWS Certificate Manager (ACM) and an Application Load Balancer (ALB) to handle SSL termination. This way, we can automate certificate management and make the setup more scalable.

@ManofWax
Copy link
Contributor Author

Hi, by using AWS services we are tying ourself to deploy only on AWS.

I want to keep the project self-hosted and deployable everywhere

@Hverma1206
Copy link

Understood! Try Certbot—it provides free SSL certificates from Let's Encrypt and automates renewals. This keeps the project self-hosted and deployable anywhere without relying on a cloud provider

@humblelad
Copy link

@ManofWax I feel like this SSL support use case should be more of the responsibility of the user, as there are multiple ways to convert http to https by changing the config files and then attaching the ssl cert. Some may prefer Let's encrypt, some mkcert and some their own ones.
Also , security teams using them would use Buffalogs in an air gap environment and maybe fine with it being run on http. This is Issue won't be that high priority is I suppose ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants