Skip to content

Commit 1c0c742

Browse files
committed
Keep meta data around task, even after disabled.
1 parent 3ac0525 commit 1c0c742

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

django_celery_beat/admin.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class PeriodicTaskAdmin(admin.ModelAdmin):
133133
}),
134134
('Schedule', {
135135
'fields': ('interval', 'crontab', 'solar', 'clocked',
136-
'start_time', 'last_run_at', 'one_off'),
136+
'start_time', 'last_run_at','total_run_count', 'one_off'),
137137
'classes': ('extrapretty', 'wide'),
138138
}),
139139
('Arguments', {
@@ -148,6 +148,7 @@ class PeriodicTaskAdmin(admin.ModelAdmin):
148148
)
149149
readonly_fields = (
150150
'last_run_at',
151+
'total_run_count'
151152
)
152153

153154
def changelist_view(self, request, extra_context=None):

django_celery_beat/models.py

-2
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,6 @@ def save(self, *args, **kwargs):
574574
self.routing_key = self.routing_key or None
575575
self.queue = self.queue or None
576576
self.headers = self.headers or None
577-
if not self.enabled:
578-
self.last_run_at = None
579577
self._clean_expires()
580578
self.validate_unique()
581579
super(PeriodicTask, self).save(*args, **kwargs)

django_celery_beat/schedulers.py

-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ def is_due(self):
125125
if self.model.one_off and self.model.enabled \
126126
and self.model.total_run_count > 0:
127127
self.model.enabled = False
128-
self.model.total_run_count = 0 # Reset
129128
self.model.no_changes = False # Mark the model entry as changed
130129
self.model.save()
131130
return schedules.schedstate(False, None) # Don't recheck

0 commit comments

Comments
 (0)