Apply suggestions from code review

Co-authored-by: campersau <[email protected]>
cefsharp · Jan 31, 2025 · fcc0cdb · fcc0cdb
1 parent 961dc2a
commit fcc0cdb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/CefSharp/Internals/LegacyJavaScriptObjectCache.cs b/CefSharp/Internals/LegacyJavaScriptObjectCache.cs
@@ -26,12 +26,7 @@ public void InsertOrUpdate(int browserId, IList<JavascriptObject> javascriptObje
         {
             foreach (var obj in javascriptObjects)
             {
-                if (cache.ContainsKey(obj.Name))
-                {
-                    cache.Remove(obj.Name);
-                }
-
-                cache.Add(obj.Name, obj);
+                cache[obj.Name] = obj;
             }
         }
 

diff --git a/CefSharp/Internals/PerBrowserJavaScriptObjectCache.cs b/CefSharp/Internals/PerBrowserJavaScriptObjectCache.cs
@@ -29,12 +29,7 @@ public void InsertOrUpdate(int browserId, IList<JavascriptObject> javascriptObje
 
             foreach (var obj in javascriptObjects)
             {
-                if (dict.ContainsKey(obj.Name))
-                {
-                    dict.Remove(obj.Name);
-                }
-
-                dict.Add(obj.Name, obj);
+                dict[obj.Name] = obj;
             }
         }