Skip to content

Commit f951f1c

Browse files
authored
Merge pull request #17 from cedadev/v0.1.3
V0.1.3
2 parents a51d34f + 645eaba commit f951f1c

10 files changed

+72
-5
lines changed

facet_scanner/__init__.py

+9
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,12 @@
55
__license__ = 'BSD - see LICENSE file in top-level package directory'
66
__contact__ = '[email protected]'
77

8+
# Logger setup
9+
import logging
10+
11+
logging.basicConfig(level=logging.DEBUG)
12+
logstream = logging.StreamHandler()
13+
14+
formatter = logging.Formatter('%(levelname)s [%(name)s]: %(message)s')
15+
logstream.setFormatter(formatter)
16+

facet_scanner/collection_handlers/base.py

+7
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@
1717
from facet_scanner.utils import generator_grouper, Singleton
1818
import time
1919

20+
from facet_scanner import logstream
21+
import logging
22+
23+
logger = logging.getLogger(__name__)
24+
logger.addHandler(logstream)
25+
logger.propagate = False
26+
2027

2128
class CollectionHandler(metaclass=Singleton):
2229
"""

facet_scanner/collection_handlers/cci.py

+12-1
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,19 @@
1111
from tqdm import tqdm
1212
import hashlib
1313
import json
14+
import logging
1415

1516
from facet_scanner.collection_handlers.base import CollectionHandler
1617
from facet_scanner.collection_handlers.utils import CatalogueDatasets
1718
from facet_scanner.utils import parse_key
1819
from tag_scanner.tagger import ProcessDatasets
1920

21+
from facet_scanner import logstream
22+
23+
logger = logging.getLogger(__name__)
24+
logger.addHandler(logstream)
25+
logger.propagate = False
26+
2027
def nested_get(key_list, input_dict, default=None):
2128
"""
2229
Takes an iterable of keys and returns none if not found or the value
@@ -113,8 +120,11 @@ def get_facets(self, path):
113120
:return: Dict Facet:value pairs
114121
"""
115122

123+
logger.debug('Getting facets for CCI-type path')
124+
116125
tagged_dataset = self.pds.get_file_tags(path)
117126

127+
logger.debug('Translating tagging code to facet map')
118128
# Translate between output from tagging code to map to named facets
119129
mapped_facets = {}
120130
for tag_name, tag_value in tagged_dataset.labels.items():
@@ -128,6 +138,7 @@ def get_facets(self, path):
128138
if tag_name == facet and tag_name_mapping is None:
129139
mapped_facets[facet] = tag_value
130140

141+
logger.debug('Obtaining moles record metadata')
131142
# Get MOLES catalogue
132143
moles_info = self.catalogue.get_moles_record_metadata(path)
133144

@@ -137,6 +148,7 @@ def get_facets(self, path):
137148
if moles_info:
138149
mapped_facets['datasetId'] = moles_info['url'].split('uuid/')[-1]
139150

151+
logger.debug('Completed facet mapping')
140152
return mapped_facets
141153

142154
@staticmethod
@@ -256,7 +268,6 @@ def _get_collection_variables(self, results, file_index):
256268

257269
if values:
258270
ids = [x['key'] for x in values]
259-
print(ids)
260271

261272
# Sample 1 netCDF file from each DRS
262273
for id in ids:

facet_scanner/collection_handlers/cmip5.py

+7
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@
1010

1111
from facet_scanner.collection_handlers.base import CollectionHandler
1212
import os
13+
import logging
14+
15+
from facet_scanner import logstream
16+
17+
logger = logging.getLogger(__name__)
18+
logger.addHandler(logstream)
19+
logger.propagate = False
1320

1421
class CMIP5(CollectionHandler):
1522
project_name = 'opensearch'

facet_scanner/core/elasticsearch_connection.py

+6
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@
1111
from elasticsearch.helpers import scan, bulk
1212
from ceda_elasticsearch_tools.elasticsearch import CEDAElasticsearchClient
1313

14+
import logging
15+
from facet_scanner import logstream
16+
17+
logger = logging.getLogger(__name__)
18+
logger.addHandler(logstream)
19+
logger.propagate = False
1420

1521
class ElasticsearchConnection:
1622
"""

facet_scanner/core/facet_scanner.py

+6
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@
1111
from facet_scanner.collection_handlers.utils import FacetFactory
1212
import logging
1313

14+
from facet_scanner import logstream
15+
1416
logger = logging.getLogger(__name__)
17+
logger.addHandler(logstream)
18+
logger.propagate = False
1519

1620

1721
class FacetScanner:
@@ -33,8 +37,10 @@ def get_handler(self, path, **kwargs):
3337
:return: Mapped collection handler
3438
:rtype: CollectionHandler
3539
"""
40+
logger.debug("Obtaining handler")
3641
handler, collection_root = self.handler_factory.get_handler(path)
3742

43+
logger.debug('Handler Obtainment complete')
3844
# Handle situation where handler not found
3945
if handler is None:
4046
logger.error(f'Unable to find a handler for: {path} in facet_scanner.collection_handlers.utils.collection_map.'

facet_scanner/scripts/facet_scanner_cmd.py

+7
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@
2424
from configparser import RawConfigParser
2525
from facet_scanner.utils import query_yes_no
2626
from facet_scanner.core.facet_scanner import FacetScanner
27+
import logging
28+
29+
from facet_scanner import logstream
30+
31+
logger = logging.getLogger(__name__)
32+
logger.addHandler(logstream)
33+
logger.propagate = False
2734

2835

2936
class FacetExtractor(FacetScanner):

facet_scanner/scripts/lotus_facet_scanner.py

+7
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@
2323
import os
2424
import json
2525

26+
import logging
27+
from facet_scanner import logstream
28+
29+
logger = logging.getLogger(__name__)
30+
logger.addHandler(logstream)
31+
logger.propagate = False
32+
2633

2734
class LotusFacetScanner(FacetExtractor):
2835

facet_scanner/utils/snippets.py

+7
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,13 @@
1111
import sys
1212
import itertools
1313
from collections import OrderedDict
14+
import logging
15+
16+
from facet_scanner import logstream
17+
18+
logger = logging.getLogger(__name__)
19+
logger.addHandler(logstream)
20+
logger.propagate = False
1421

1522

1623
def query_yes_no(question, default="yes"):

pyproject.toml

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "facet-scanner"
3-
version = "0.1.1"
3+
version = "0.1.3"
44
description = "Extracts facets from datasets to add to elasticsearch."
55
authors = ["Daniel Westwood <[email protected]>"]
66
license = "{file='LICENSE'}"
@@ -24,10 +24,10 @@ python = "^3.12"
2424
elasticsearch = "^7"
2525
requests = "^2.32.3"
2626
tqdm = "^4.66.6"
27-
sphinx = "^8.1.3"
28-
directory-tree = { git = "https://github.com/cedadev/ceda-directory-tree.git", tag = "v1.1.2" }
27+
sphinx = "^7"
28+
directory-tree = { git = "https://github.com/cedadev/ceda-directory-tree.git", tag = "v1.1.3" }
2929
ceda-elasticsearch-tools = { git = "https://github.com/cedadev/ceda-elasticsearch-tools.git", tag = "v2.4.0" }
30-
tag-scanner = { git = "https://github.com/cedadev/cci-tag-scanner.git", tag = "v2.1.3" }
30+
tag-scanner = { git = "https://github.com/cedadev/cci-tag-scanner.git", tag = "v2.1.6" }
3131
pytest = "^8.3.3"
3232

3333

0 commit comments

Comments
 (0)