Skip to content

Commit 54fd13b

Browse files
holgerfriedrichholgerfriedrich
authored
Reduce SAT warnings (openhab#17406)
* Reduce SAT warnings Signed-off-by: Holger Friedrich <[email protected]>
1 parent 2d61ffc commit 54fd13b

File tree

107 files changed

+146
-216
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

107 files changed

+146
-216
lines changed

Diff for: ‎bundles/org.openhab.automation.jrubyscripting/src/main/resources/OH-INF/config/config.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<parameter name="gems" type="text" required="false" groupName="gems">
2727
<label>Ruby Gems</label>
2828
<description><![CDATA[A comma separated list of Ruby Gems to install. Versions may be constrained by separating with an
29-
<tt>=</tt> and then the standard RubyGems version constraint, such as "<tt>openhab-scripting=~>5.0</tt>".
29+
<tt>=</tt> and then the standard RubyGems version constraint, such as "<tt>openhab-scripting=~>5.0</tt>".
3030
]]></description>
3131
<default>openhab-scripting=~>5.0.0</default>
3232
</parameter>

Diff for: ‎bundles/org.openhab.binding.airgradient/src/main/java/org/openhab/binding/airgradient/internal/handler/DynamicChannelHelper.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class DynamicChannelHelper {
3838
private record ConfigurationChannel(String id, String typeId, String itemType) {
3939
}
4040

41-
private final static List<ConfigurationChannel> channels = new ArrayList<ConfigurationChannel>() {
41+
private static final List<ConfigurationChannel> CHANNELS = new ArrayList<ConfigurationChannel>() {
4242
{
4343
add(new ConfigurationChannel(CHANNEL_COUNTRY_CODE, CHANNEL_COUNTRY_CODE, "String"));
4444
add(new ConfigurationChannel(CHANNEL_PM_STANDARD, CHANNEL_PM_STANDARD, "String"));
@@ -58,10 +58,10 @@ private record ConfigurationChannel(String id, String typeId, String itemType) {
5858
}
5959
};
6060

61-
private final static Logger logger = LoggerFactory.getLogger(DynamicChannelHelper.class);
61+
private static final Logger logger = LoggerFactory.getLogger(DynamicChannelHelper.class);
6262

6363
public static ThingBuilder updateThingWithConfigurationChannels(Thing thing, ThingBuilder builder) {
64-
for (ConfigurationChannel channel : channels) {
64+
for (ConfigurationChannel channel : CHANNELS) {
6565
addLocalConfigurationChannel(thing, builder, channel);
6666
}
6767

Diff for: ‎bundles/org.openhab.binding.astro/src/main/java/org/openhab/binding/astro/internal/handler/SunHandler.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,12 @@
2121
import org.openhab.binding.astro.internal.calc.SunCalc;
2222
import org.openhab.binding.astro.internal.job.DailyJobSun;
2323
import org.openhab.binding.astro.internal.job.Job;
24-
import org.openhab.binding.astro.internal.model.*;
24+
import org.openhab.binding.astro.internal.model.Planet;
25+
import org.openhab.binding.astro.internal.model.Position;
26+
import org.openhab.binding.astro.internal.model.Radiation;
27+
import org.openhab.binding.astro.internal.model.Range;
28+
import org.openhab.binding.astro.internal.model.Sun;
29+
import org.openhab.binding.astro.internal.model.SunPhaseName;
2530
import org.openhab.core.i18n.TimeZoneProvider;
2631
import org.openhab.core.scheduler.CronScheduler;
2732
import org.openhab.core.thing.Thing;

Diff for: ‎bundles/org.openhab.binding.awattar/src/main/java/org/openhab/binding/awattar/internal/handler/AwattarBridgeHandler.java

-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ private boolean needRefresh() {
207207

208208
// refresh then every 3 hours, if the last refresh was more than an hour ago
209209
if (now.getHour() % 3 == 0 && lastRefresh.getEpochSecond() < now.minusHours(1).toEpochSecond()) {
210-
211210
// update the last refresh time
212211
lastRefresh = Instant.now();
213212

Diff for: ‎bundles/org.openhab.binding.awattar/src/test/java/org/openhab/binding/awattar/internal/handler/AwattarBridgeHandlerRefreshTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ class AwattarBridgeHandlerRefreshTest extends JavaTest {
7373

7474
@BeforeEach
7575
public void setUp() throws IllegalArgumentException, IllegalAccessException {
76-
7776
when(timeZoneProviderMock.getTimeZone()).thenReturn(ZoneId.of("GMT+2"));
7877

7978
when(bridgeMock.getUID()).thenReturn(BRIDGE_UID);

Diff for: ‎bundles/org.openhab.binding.awattar/src/test/java/org/openhab/binding/awattar/internal/handler/AwattarBridgeHandlerTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ public class AwattarBridgeHandlerTest extends JavaTest {
9595

9696
@BeforeEach
9797
public void setUp() throws IOException, IllegalArgumentException, IllegalAccessException, AwattarApiException {
98-
9998
// mock the API response
10099
try (InputStream inputStream = AwattarBridgeHandlerTest.class.getResourceAsStream("api_response.json")) {
101100
SortedSet<AwattarPrice> result = new TreeSet<>(Comparator.comparing(AwattarPrice::timerange));

Diff for: ‎bundles/org.openhab.binding.bluetooth.airthings/src/main/java/org/openhab/binding/bluetooth/airthings/internal/AirthingsWaveGen1Handler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* The {@link AirthingsWaveGen1Handler} is responsible for handling commands, which are
2929
* sent to one of the channels.
3030
*
31-
* @author Davy Wong - Added Airthings Wave Gen 1 support
31+
* @author Davy Wong - initial contribution, added Airthings Wave Gen 1 support
3232
*/
3333
@NonNullByDefault
3434
public class AirthingsWaveGen1Handler extends AbstractAirthingsHandler {

Diff for: ‎bundles/org.openhab.binding.bluetooth.daikinmadoka/src/main/java/org/openhab/binding/bluetooth/daikinmadoka/internal/model/MadokaValue.java

-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ public long getComputedValue(ByteOrder e) {
9191
// unsupported
9292
break;
9393
}
94-
9594
}
9695
return 0;
9796
}

Diff for: ‎bundles/org.openhab.binding.bluetooth.generic/src/main/java/org/openhab/binding/bluetooth/generic/internal/BluetoothChannelUtils.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
/**
4141
* The {@link BluetoothChannelUtils} contains utility functions used by the GattChannelHandler
4242
*
43-
* @author Vlad Kolotov - Original author
43+
* @author Vlad Kolotov - Initial contribution
4444
* @author Connor Petty - Modified for openHAB use
4545
*/
4646
@NonNullByDefault
@@ -75,11 +75,11 @@ public static String decodeFieldName(String encodedFieldName) {
7575
case SINT:
7676
case FLOAT_IEE754:
7777
case FLOAT_IEE11073:
78-
BluetoothUnit unit = BluetoothUnit.findByType(field.getUnit());
79-
if (unit != null) {
80-
// TODO
81-
// return "Number:" + unit.getUnit().getDimension();
82-
}
78+
// BluetoothUnit unit = BluetoothUnit.findByType(field.getUnit());
79+
// if (unit != null) {
80+
// TODO
81+
// return "Number:" + unit.getUnit().getDimension();
82+
// }
8383
return "Number";
8484
case UTF8S:
8585
case UTF16S:
@@ -208,7 +208,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
208208
if (decimalType != null) {
209209
try {
210210
return field.getEnumeration(new BigInteger(decimalType.toString()));
211-
} catch (NumberFormatException ex) {
211+
} catch (NumberFormatException ignored) {
212212
// do nothing
213213
}
214214
}

Diff for: ‎bundles/org.openhab.binding.bluetooth.generic/src/main/java/org/openhab/binding/bluetooth/generic/internal/CharacteristicChannelTypeProvider.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
/**
4343
* {@link CharacteristicChannelTypeProvider} that provides channel types for dynamically discovered characteristics.
4444
*
45-
* @author Vlad Kolotov - Original author
45+
* @author Vlad Kolotov - Initial contribution
4646
* @author Connor Petty - Modified for openHAB use.
4747
*/
4848
@NonNullByDefault

Diff for: ‎bundles/org.openhab.binding.cm11a/src/main/java/org/openhab/binding/cm11a/internal/X10Interface.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
* Driver for the CM11 X10 interface.
4848
*
4949
*
50-
* @author Anthony Green - Original code
50+
* @author Anthony Green - Initial contribution
5151
* @author Bob Raker - updates to setClock code, adapted code for use in openHAB2
5252
* @see <a href="http://www.heyu.org/docs/protocol.txt">CM11 Protocol specification</a>
5353
* @see <a href="http://www.rxtx.org">RXTX Serial API for Java</a>

Diff for: ‎bundles/org.openhab.binding.digitalstrom/src/main/java/org/openhab/binding/digitalstrom/internal/discovery/SceneDiscoveryService.java

-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ private void onSceneAddedInternal(InternalScene scene) {
113113
.withBridge(bridgeUID).withLabel(scene.getSceneName()).build();
114114

115115
thingDiscovered(discoveryResult);
116-
117116
} else {
118117
logger.debug("discovered unsupported scene: name '{}' with id {}", scene.getSceneName(),
119118
scene.getID());

Diff for: ‎bundles/org.openhab.binding.digitalstrom/src/main/java/org/openhab/binding/digitalstrom/internal/handler/CircuitHandler.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
* For that it uses the {@link BridgeHandler} to register this class as a {@link DeviceStatusListener} to get informed
4848
* about changes from the accompanying {@link Circuit}.
4949
*
50-
* @author Michael Ochel
51-
* @author Matthias Siegele
50+
* @author Michael Ochel - Initial contribution
51+
* @author Matthias Siegele - Initial contribution
5252
*/
5353
public class CircuitHandler extends BaseThingHandler implements DeviceStatusListener {
5454

Diff for: ‎bundles/org.openhab.binding.digitalstrom/src/main/java/org/openhab/binding/digitalstrom/internal/lib/serverconnection/constants/JSONApiResponseKeysEnum.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
* The {@link JSONApiResponseKeysEnum} contains digitalSTROM-JSON response keys.
1717
*
1818
* @author Alexander Betker - Initial contribution
19-
* @author Michael Ochel completely changed and updated only methods remained
20-
* @author Matthias Siegele completely changed and updated only methods remained
19+
* @author Michael Ochel - completely changed and updated only methods remained
20+
* @author Matthias Siegele - completely changed and updated only methods remained
2121
*/
2222
public enum JSONApiResponseKeysEnum {
2323

Diff for: ‎bundles/org.openhab.binding.draytonwiser/src/main/java/org/openhab/binding/draytonwiser/internal/handler/ControllerHandler.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ private State getSignalStrength() {
112112
}
113113

114114
private State getHeatChannel1Demand() {
115-
return getData().heatingChannels.size() >= 1
115+
return !getData().heatingChannels.isEmpty()
116116
? new QuantityType<>(getData().heatingChannels.get(0).getPercentageDemand(), Units.PERCENT)
117117
: UnDefType.UNDEF;
118118
}
@@ -124,7 +124,7 @@ private State getHeatChannel2Demand() {
124124
}
125125

126126
private State getHeatChannel1DemandState() {
127-
return OnOffType.from(getData().heatingChannels.size() >= 1
127+
return OnOffType.from(!getData().heatingChannels.isEmpty()
128128
&& "ON".equalsIgnoreCase(getData().heatingChannels.get(0).getHeatingRelayState()));
129129
}
130130

Diff for: ‎bundles/org.openhab.binding.draytonwiser/src/main/java/org/openhab/binding/draytonwiser/internal/handler/HotWaterHandler.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ private void setBoostDuration(final int durationMinutes) throws DraytonWiserApiE
110110
}
111111

112112
private State getBoostedState() {
113-
if (getData().hotWater.size() >= 1) {
113+
if (!getData().hotWater.isEmpty()) {
114114
final HotWaterDTO firstChannel = getData().hotWater.get(0);
115115

116116
if (firstChannel.getOverrideTimeoutUnixTime() != null
@@ -125,7 +125,7 @@ private State getBoostedState() {
125125
}
126126

127127
private State getBoostRemainingState() {
128-
if (getData().hotWater.size() >= 1) {
128+
if (!getData().hotWater.isEmpty()) {
129129
final HotWaterDTO firstChannel = getData().hotWater.get(0);
130130
final Integer overrideTimeout = firstChannel.getOverrideTimeoutUnixTime();
131131

Diff for: ‎bundles/org.openhab.binding.easee/src/main/java/org/openhab/binding/easee/internal/model/GenericResponseTransformer.java

-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ public Map<Channel, State> transform(JsonObject jsonData, String group) {
121121
// call the custom handler to handle specific / composite channels which do not map 1:1 to JSON
122122
// fields.
123123
result.putAll(customResponseTransformer.transform(channel, value, jsonData));
124-
125124
} catch (NumberFormatException | DateTimeParseException ex) {
126125
logger.warn("caught exception while parsing data for channel {} (value '{}'). Exception: {}",
127126
channel.getUID().getId(), value, ex.getMessage());

Diff for: ‎bundles/org.openhab.binding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java

-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,6 @@ private void handleStatusUpdate(EmotivaUdpResponse emotivaUdpResponse) {
328328
if (object instanceof EmotivaAckDTO answerDto) {
329329
// Currently not supported to revert a failed command update, just used for logging for now.
330330
logger.trace("Processing received '{}' with '{}'", EmotivaAckDTO.class.getSimpleName(), answerDto);
331-
332331
} else if (object instanceof EmotivaBarNotifyWrapper answerDto) {
333332
logger.trace("Processing received '{}' with '{}'", EmotivaBarNotifyWrapper.class.getSimpleName(),
334333
emotivaUdpResponse.answer());

Diff for: ‎bundles/org.openhab.binding.enocean/src/main/resources/OH-INF/thing/channels.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -438,14 +438,14 @@
438438
</channel-type>
439439

440440
<channel-type id="autoOFF" advanced="true">
441-
<item-type>Number:Duration</item-type>
441+
<item-type>Number:Time</item-type>
442442
<label>Auto Off</label>
443443
<description>Automatically switch to off</description>
444444
<state pattern="%d %unit%"/>
445445
</channel-type>
446446

447447
<channel-type id="delayRadioOFF" advanced="true">
448-
<item-type>Number:Duration</item-type>
448+
<item-type>Number:Time</item-type>
449449
<label>Delay Radio Off</label>
450450
<description>Delay switch off by radio for given seconds</description>
451451
<state pattern="%d %unit%"/>

Diff for: ‎bundles/org.openhab.binding.enphase/src/main/java/org/openhab/binding/enphase/internal/handler/EnvoyEntrezConnector.java

-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ public String setConfiguration(final EnvoyConfiguration configuration) {
7979
check(configuration.password, "Password parameter is empty"),
8080
check(configuration.siteName, "siteName parameter is empty"))
8181
.filter(s -> !s.isEmpty()).collect(Collectors.joining(", "));
82-
8382
}
8483
if (!message.isEmpty()) {
8584
return message;

Diff for: ‎bundles/org.openhab.binding.freeboxos/src/main/resources/OH-INF/config/bridge-config.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xmlns:config-description="https://openhab.org/schemas/config-description/v1.0.0"
55
xsi:schemaLocation="https://openhab.org/schemas/config-description/v1.0.0
6-
https://openhab.org/schemas/config-description-1.0.0.xsd">
6+
https://openhab.org/schemas/config-description-1.0.0.xsd">
77

88
<config-description uri="bridge-type:freeboxos:api">
99
<parameter name="apiDomain" type="text">

Diff for: ‎bundles/org.openhab.binding.fsinternetradio/src/main/java/org/openhab/binding/fsinternetradio/internal/radio/FrontierSiliconRadio.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* Class representing an internet radio based on the frontier silicon chipset. Tested with "hama IR110" and Medion
2323
* MD87180" internet radios.
2424
*
25-
* @author Rainer Ostendorf
26-
* @author Patrick Koenemann
25+
* @author Rainer Ostendorf - Initial contribution
26+
* @author Patrick Koenemann - improvements
2727
* @author Mihaela Memova - removed duplicated check for the percent value range
2828
*/
2929
public class FrontierSiliconRadio {

Diff for: ‎bundles/org.openhab.binding.fsinternetradio/src/main/java/org/openhab/binding/fsinternetradio/internal/radio/FrontierSiliconRadioApiResult.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
*
4444
* This class parses this XML data and provides functions for reading and casting typical fields.
4545
*
46-
* @author Rainer Ostendorf
47-
* @author Patrick Koenemann
46+
* @author Rainer Ostendorf - Initial contribution
47+
* @author Patrick Koenemann - Improvements
4848
*
4949
*/
5050
public class FrontierSiliconRadioApiResult {

Diff for: ‎bundles/org.openhab.binding.fsinternetradio/src/main/java/org/openhab/binding/fsinternetradio/internal/radio/FrontierSiliconRadioConnection.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
/**
2727
* This class holds the http-connection and session information for controlling the radio.
2828
*
29-
* @author Rainer Ostendorf
30-
* @author Patrick Koenemann
29+
* @author Rainer Ostendorf - Initial contribution
30+
* @author Patrick Koenemann - improvements
3131
* @author Svilen Valkanov - replaced Apache HttpClient with Jetty
3232
* @author Mihaela Memova - changed the calling of the stopHttpClient() method, fixed the hardcoded URL path, fixed the
3333
* for loop condition part
@@ -110,7 +110,6 @@ public boolean doLogin() throws IOException {
110110
isLoggedIn = true;
111111
return true; // login successful :-)
112112
}
113-
114113
} catch (Exception e) {
115114
logger.debug("Fatal transport error: {}", e.toString());
116115
throw new IOException(e);

Diff for: ‎bundles/org.openhab.binding.fsinternetradio/src/main/java/org/openhab/binding/fsinternetradio/internal/radio/FrontierSiliconRadioConstants.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
/**
1616
* Internal constants for the frontier silicon radio.
1717
*
18-
* @author Markus Rathgeb - Moved the constants to separate class
18+
* @author Markus Rathgeb - Initial contribution, moved the constants to separate class
1919
*/
2020
public class FrontierSiliconRadioConstants {
2121

Diff for: ‎bundles/org.openhab.binding.groupepsa/src/main/java/org/openhab/binding/groupepsa/internal/things/GroupePSAHandler.java

-2
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ public void initialize() {
154154
this.onlineIntervalM = onlineIntervalM != null ? onlineIntervalM : DEFAULT_ONLINE_INTERVAL_M;
155155
startGroupePSAPolling(pollingIntervalM);
156156
}
157-
158157
} else {
159158
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_UNINITIALIZED);
160159
}
@@ -359,7 +358,6 @@ private void updateChannelState(VehicleStatus vehicle) {
359358
Charging::getRemainingTime, x -> new BigDecimal(x.getSeconds()), Units.SECOND);
360359
updateState(CHANNEL_ELECTRIC_CHARGING_NEXTDELAYEDTIME, energy, Energy::getCharging,
361360
Charging::getNextDelayedTime, x -> new BigDecimal(x.getSeconds()), Units.SECOND);
362-
363361
}
364362
}
365363
}

Diff for: ‎bundles/org.openhab.binding.growatt/src/main/java/org/openhab/binding/growatt/internal/cloud/GrowattCloud.java

-1
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,6 @@ public void setupBatteryProgram(String deviceId, int programModeInt, @Nullable I
508508

509509
DeviceType deviceType = getDeviceTypeChecked(deviceId);
510510
switch (deviceType) {
511-
512511
case MIX:
513512
case SPA:
514513
setTimeProgram(deviceId, deviceType,

Diff for: ‎bundles/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/internal/common/AuthenticationHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
/**
2424
* Handles the authentication to Homematic server.
2525
*
26-
* @author Christian Kittel
26+
* @author Christian Kittel - Initial contribution
2727
*/
2828
@NonNullByDefault
2929
public class AuthenticationHandler {

Diff for: ‎bundles/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/internal/discovery/HomematicDeviceDiscoveryService.java

-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ private void disableInstallMode() {
123123
thingHandler.getGateway().setInstallMode(false, 0);
124124
}
125125
}
126-
127126
} catch (Exception ex) {
128127
logger.warn("Failed to disable Homematic controller's install mode", ex);
129128
}

Diff for: ‎bundles/org.openhab.binding.homewizard/src/main/java/org/openhab/binding/homewizard/internal/HomeWizardDeviceHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public void dispose() {
103103
*
104104
* @param payload The data parsed from the data Json file
105105
*/
106-
abstract protected void handleDataPayload(DataPayload payload);
106+
protected abstract void handleDataPayload(DataPayload payload);
107107

108108
/**
109109
*

Diff for: ‎bundles/org.openhab.binding.homewizard/src/main/java/org/openhab/binding/homewizard/internal/HomeWizardStatefulDeviceHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public HomeWizardStatefulDeviceHandler(Thing thing) {
4747
*
4848
* @param payload The data parsed from the state Json file
4949
*/
50-
abstract protected void handleStatePayload(StatePayload payload);
50+
protected abstract void handleStatePayload(StatePayload payload);
5151

5252
protected void pollState() {
5353
final String stateResult;

Diff for: ‎bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2BridgeHandler.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ public class Clip2BridgeHandler extends BaseBridgeHandler {
119119
private final Bundle bundle;
120120
private final LocaleProvider localeProvider;
121121
private final TranslationProvider translationProvider;
122-
private final Map<String, Resource> automationsCache = new ConcurrentHashMap<>();;
122+
private final Map<String, Resource> automationsCache = new ConcurrentHashMap<>();
123123
private final Set<String> automationScriptIds = ConcurrentHashMap.newKeySet();
124124
private final ChannelGroupUID automationChannelGroupUID;
125125

@@ -853,7 +853,6 @@ private void updateAutomationChannels() {
853853
Resource cachedAutomation = automationsCache.get(automation.getId());
854854
return Objects.isNull(cachedAutomation) || !automation.getName().equals(cachedAutomation.getName());
855855
})) {
856-
857856
synchronized (automationsCache) {
858857
automationsCache.clear();
859858
automationsCache.putAll(automations.stream().collect(Collectors.toMap(a -> a.getId(), a -> a)));

Diff for: ‎bundles/org.openhab.binding.icloud/src/main/java/org/openhab/binding/icloud/internal/handler/ICloudDeviceHandler.java

-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ public void handleCommand(ChannelUID channelUID, Command command) {
140140
if (channelId.equals(FIND_MY_PHONE)) {
141141
if (command == OnOffType.ON) {
142142
try {
143-
144143
if (deviceInformationRecord == null) {
145144
this.logger
146145
.debug("Can't send Find My Device request, because deviceInformationRecord is null!");

Diff for: ‎bundles/org.openhab.binding.ihc/src/main/java/org/openhab/binding/ihc/internal/profiles/PushButtonToCommandProfile.java

-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ private long getParamAsLong(String param, long defValue) {
117117
logger.warn("Parameter '{}' is not a valid command type, using default value '{}'", param, defValue);
118118
retval = defValue;
119119
}
120-
121120
} else {
122121
logger.debug("Parameter '{}' is not of type String, using default value '{}'", param, defValue);
123122
retval = defValue;

0 commit comments

Comments
 (0)