Merge pull request #3938 from ccnmtl/eslint-9

⬆️ eslint 9.27.0

Author: nikolas

.eslintrc.cjs

@@ -0,0 +1,104 @@
+import { defineConfig } from 'eslint/config';
+import react from 'eslint-plugin-react';
+import security from 'eslint-plugin-security';
+import globals from 'globals';
+import babelParser from '@babel/eslint-parser';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default defineConfig([
+    js.configs.recommended, {
+        extends: compat.extends(
+            'eslint:recommended',
+            'plugin:react/recommended',
+            'plugin:security/recommended-legacy',
+        ),
+
+        plugins: {
+            react,
+            security,
+        },
+
+        files: [
+            '**/*.mjs', '**/*.jsx'
+        ],
+
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+                ...globals.amd,
+                ...globals.jquery,
+            },
+
+            parser: babelParser,
+            ecmaVersion: 'latest',
+            sourceType: 'module',
+
+            parserOptions: {
+                ecmaFeatures: {
+                    jsx: true,
+                },
+            },
+        },
+
+        settings: {
+            react: {
+                version: 'detect',
+            },
+        },
+
+        rules: {
+            indent: ['error', 4, {
+                SwitchCase: 1,
+            }],
+
+            'linebreak-style': ['error', 'unix'],
+
+            'no-unused-vars': ['error', {
+                vars: 'all',
+                args: 'none',
+            }],
+
+            quotes: ['error', 'single'],
+            semi: ['error', 'always'],
+            'security/detect-buffer-noassert': 1,
+            'security/detect-child-process': 1,
+            'security/detect-disable-mustache-escape': 1,
+            'security/detect-eval-with-expression': 1,
+            'security/detect-new-buffer': 1,
+            'security/detect-no-csrf-before-method-override': 1,
+            'security/detect-non-literal-fs-filename': 1,
+            'security/detect-non-literal-regexp': 1,
+            'security/detect-non-literal-require': 0,
+            'security/detect-object-injection': 0,
+            'security/detect-possible-timing-attacks': 1,
+            'security/detect-pseudoRandomBytes': 1,
+            'security/detect-unsafe-regex': 1,
+        },
+    }, {
+        files: ['**/*.js'],
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+                ...globals.jquery
+            }
+        }
+    }, {
+        files: ['**/*.test.js', '**/*.test.jsx', '**/*.test.mjs'],
+        languageOptions: {
+            globals: {
+                ...globals.jest,
+            }
+        }
+    }
+]);

eslint.config.mjs

@@ -1,4 +1,4 @@
-/* eslint-env node */
+/* global process */
 
 'use strict';
 

media/js/config/env.cjs

@@ -1,4 +1,4 @@
-/* eslint-env node */
+/* global process */
 
 'use strict';
 
@@ -48,11 +48,11 @@ module.exports = {
     dotenv: resolveApp('.env'),
     appBuild: resolveApp(JS_PATH + 'build'),
     appPublic: resolveApp(JS_PATH + 'public'),
-    appEditorJs: resolveApp(JS_PATH + 'src/editor-main.js'),
-    appViewerJs: resolveApp(JS_PATH + 'src/viewer-main.js'),
-    appStepGraphViewerJs: resolveApp(JS_PATH + 'src/stepGraphViewer-main.js'),
-    appRubricJs: resolveApp(JS_PATH + 'src/rubric-main.js'),
-    appGraphPreviewJs: resolveApp(JS_PATH + 'src/graphPreview-main.js'),
+    appEditorJs: resolveApp(JS_PATH + 'src/editor-main.jsx'),
+    appViewerJs: resolveApp(JS_PATH + 'src/viewer-main.jsx'),
+    appStepGraphViewerJs: resolveApp(JS_PATH + 'src/stepGraphViewer-main.jsx'),
+    appRubricJs: resolveApp(JS_PATH + 'src/rubric-main.jsx'),
+    appGraphPreviewJs: resolveApp(JS_PATH + 'src/graphPreview-main.jsx'),
     appPackageJson: resolveApp('package.json'),
     appSrc: resolveApp(JS_PATH + 'src'),
     yarnLockFile: resolveApp('yarn.lock'),

media/js/config/paths.cjs

@@ -1,4 +1,4 @@
-/* eslint-env node */
+/* global process */
 
 'use strict';
 

media/js/config/webpack.config.dev.cjs

@@ -1,4 +1,4 @@
-/* eslint-env node */
+/* global process */
 
 'use strict';
 

media/js/config/webpack.config.prod.cjs

@@ -1,4 +1,5 @@
 /* eslint-env node */
+/* global process */
 
 import React from 'react';
 import PropTypes from 'prop-types';

media/js/src/AreaDisplay.test.js renamed to media/js/src/AreaDisplay.test.mjs

@@ -22,7 +22,7 @@ export default class TemplateGraphEditor extends React.Component {
         try {
             math.evaluate(expression, { x: 1 });
             return true;
-        } catch (e) {
+        } catch {
             return false;
         }
     }

media/js/src/Editor.test.js renamed to media/js/src/Editor.test.jsx

@@ -138,7 +138,7 @@ export class CostFunctionsGraph extends Graph {
                 return cost(q, me.options.gA1, me.options.gA2, me.options.gA3);
             };
 
-            const f2 = function(q) {
+            const f2 = function() {
                 return fcost(me.options.gA1);
             };
 
@@ -192,7 +192,7 @@ export class CostFunctionsGraph extends Graph {
                 return mcost(q, me.options.gA1, me.options.gA2, me.options.gA3);
             };
 
-            const f2 = function(q) {
+            const f2 = function() {
                 return acost(me.options.gA1);
             };
 

media/js/src/GraphEditor.test.js renamed to media/js/src/GraphEditor.test.jsx

@@ -112,11 +112,11 @@ const u1f1 = function(x, px, py, R, alpha, beta) {
     return (UStar / (x ** alpha)) ** (1 / beta);
 };
 
-const xstarvalue2 = function(px, py, R, alpha, beta) {
+const xstarvalue2 = function(px, py, R, alpha) {
     return (R * alpha) / px;
 };
 
-const ystarvalue2 = function(px, py, R, alpha, beta) {
+const ystarvalue2 = function(px, py, R, alpha) {
     return -((-R + R * alpha) / py);
 };
 
@@ -276,15 +276,15 @@ const u7f1 = function(x, px, py, R, a, b) {
     }
 };
 
-const xstarvalue8 = function(px, py, R, a, b) {
+const xstarvalue8 = function(px, py, R, a) {
     if (0 < (R / px)) {
         return (a * py) / px;
     }
 
     return 0;
 };
 
-const ystarvalue8 = function(px, py, R, a, b) {
+const ystarvalue8 = function(px, py, R, a) {
     if (R > py) {
         return (R / py) - a;
     }

media/js/src/JXGBoard.jsx

@@ -128,7 +128,7 @@ const isocost0 = function(w, r, c, l, alpha, beta) {
     };*/
 
 // Function choice: 1
-const isocost1 = function(w, r, q, l, alpha, beta) {
+const isocost1 = function(w, r, q, l, alpha) {
     return (-l*w + q*r*(-alpha*w/(r*(alpha - 1)))**(1 - alpha) +
         q*w*(r*(1 - alpha)/(alpha*w))**alpha) / r;
 };
@@ -259,7 +259,7 @@ const lStarValue6 = function(q, w, r, a, b) {
     return q / b;
 };
 
-const kStarValue6 = function(q, w, r, a, b) {
+const kStarValue6 = function(q, w, r, a) {
     return q / a;
 };
 

media/js/src/JXGBoard.test.js renamed to media/js/src/JXGBoard.test.jsx

@@ -13,7 +13,7 @@ const epsilonP = function(c) {
 
 const r  = function(b, c, q) {
     return q * fp(b, c, q);};
-const rBCEpQ = function(b, c, q) {
+const rBCEpQ = function(b, c) {
     return c * c * b / 4;};
 const rP = function(b, c, p) {
     return p * fq(b, c, p);};

media/js/src/editor-main.js renamed to media/js/src/editor-main.jsx

@@ -26,7 +26,7 @@ const getFunc = function(expression, fallback='fallback', x) {
     try {
         func = math.evaluate(expression, scope);
         window.EconPlayground[fallback] = expression;
-    } catch (e) {
+    } catch {
         func = math.evaluate(window.EconPlayground[fallback], scope);
     }
 

media/js/src/editors/TemplateGraphEditor.jsx

@@ -1,4 +1,4 @@
-/* globals process, Promise */
+/* globals process */
 
 const BOARD_WIDTH = 540;
 const BOARD_HEIGHT = 300;