Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairing item bugs #5939

Open
hiro9888 opened this issue Jan 18, 2025 · 2 comments
Open

Repairing item bugs #5939

hiro9888 opened this issue Jan 18, 2025 · 2 comments
Labels
bug confirmed Bug that has been reproduced src changes related to source code.

Comments

@hiro9888
Copy link

hiro9888 commented Jan 18, 2025

Describe the bug

1.When using rag (filthy) / kevlar plate (filthy) to repair a clean dress shirt / MBR vest by sewing kit, it will report an error.
2.When using clean rag/ kevlar plate to repair a dress shirt (filthy) / MBR vest (filthy) by sewing kit, it will report same error, too.
3.But if using clean rag repair clean item, or (filthy) rag repair (filthy) item, it is no problem.

Steps To Reproduce

  1. prepare a rag (filthy)
  2. prepare a sewing kit (reloaded already)
  3. prepare a clean dress shirt (damaged but can be repaired)
  4. use your rag (filthy) repair the dress shirt by sewing kit
  5. same error occur when use clean rag repair a dress shirt (filthy).
  6. same error occur when use kevlar plate (filthy) to repair clean MBR vest or other similar items.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4894 (22H2)
  • Game Version: f1679cc [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    No Rail Stations [No_Rail_Stations],
    Limit Fungal Growth [limit_fungal_growth],
    Item Category Overhaul [Item_Category_Overhaul],
    Prevent Zombie Revivication [no_reviving_zombies]
    ]

Additional context

DEBUG : Attempted a recipe with no available components!

FUNCTION : comp_selection<item_comp> player::select_item_component(const std::vector<item_comp>&, int, inventory&, bool, const std::function<bool(const item&)>&, bool)
FILE : src/crafting.cpp
LINE : 1469
VERSION : BN f1679cc

@hiro9888 hiro9888 added the bug label Jan 18, 2025
@RoyalFox2140
Copy link
Collaborator

Filthy clothing is due for obsoletion as per conversations with Chaosvolt and Coolthulhu, reasonings and conversation about it can be found on the Discord but in short they don't really feel it adds to the gameplay.

Leaving it open for now because it's a valid bug until someone does obsolete filthy clothing.

@RoyalFox2140 RoyalFox2140 added confirmed Bug that has been reproduced src changes related to source code. labels Jan 18, 2025
@hiro9888
Copy link
Author

Filthy clothing is due for obsoletion as per conversations with Chaosvolt and Coolthulhu, reasonings and conversation about it can be found on the Discord but in short they don't really feel it adds to the gameplay.

Leaving it open for now because it's a valid bug until someone does obsolete filthy clothing.

Yes I also hate filthy clothing cause it is not an interesting part of gameplay, like a hassle, even more in repairing. I remember that it does not exist in the early version. Maybe I need use No_Filthy_Clothes mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced src changes related to source code.
Projects
None yet
Development

No branches or pull requests

2 participants