-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why don't you make a Github Pages website? #56
Comments
It'd be good to make this page access through github api's to get all files and not copypasting |
Off-topic, but are you the Shadman? |
Do you mean like some kind web page where you could view the images more easily. If thats what you mean I would definitely be open to doing that, and adding it as project for the repo. |
As a professional web developer, heck c*rousels. |
Sounds like you're overthinking it. Pick a Hugo gallery template, tweak it a bit, and you're done. |
I'm interested in working on this so I made a rough mockup. The colors and overall layout will probably change but this is as far as I can push my creative boundaries at 9am. There are certain images that are extremely off center so we might need to keep some configuration files Let me know what you think, happy to do tweaks or start working on the real thing. It would most likely be in Gatsby to address problems like gigantic image sizes and loading of the metadata I mentioned earlier. We could even go as far as to offer zip files of the entire archive if that's something you would be interested in. EDIT: Also I noticed that you guys are starting to run out of space so we could eventually override the images with the |
that looks really good. do you think we should start a separate repo for the pages source or would cramming it into a folder on this repo be better |
It's probably better to keep everything in one place because this repo will be the "one source of truth" so just making a |
We can always stuff it into the |
@Xetera where do you see that we're running out of space? The repo is only at 88MB, which is way under the recommended 1GB limit (and the hard limit is 100GB, which is even further off). If you're thinking that the limit is 100MB, that's for individual files. |
That's not what branches are for though... I don't see why you wouldn't want |
That's not what branches are commonly used for, but it's still a valid use of a branch. It's perfectly valid to say that all Web-related code is developed on another branch. One might argue that that's a reason for it to be in another repo, and that's also a perfectly fine option as well. The only argument I have for it being in the same repo is that it's tightly coupled with this repo; if the site is general enough that it's only loosely coupled, then it should go in a different repo. I'd rather keep it out of |
What's your definition of "valid use"? Sure it would work, but it would be a lot more work to maintain. Why make that harder? I'm speaking from the experience of dealing with |
@bucket3432 oh whoops, I guess I misread the earlier conversation. In that case, it doesn't really matter if the images themselves are large or not. I was thinking it would be more convenient to deploy the website on Netlify. There wouldn't need to be any html file involved in the repo at all, just the source code for the website. The repo I have now with a semi-working website is just the exact setup you guys have in this repo except with a |
If you literally rename |
That works too, but then we'll need travis or circle CI to compile the react code into html and push to a new branch. It's also possible to do it with pure html and js and not bother with a static site generator but then we'd be serving 12M of images for C and 31M for SICP, I don't think anyone would like that. I'm fine with setting up a simple build step with Travis CI, it already supports this kind of thing by default but there's a tiny bit of configuration to be done on the repo owner's end. |
I didn't think about thumbnailing, you are right. Shame there's no good service for that. |
Alright, I concede the point in the context of GitHub. In that case, I don't have any strong reasons for or against either way. As for thumbnailing, we can probably run something on the CI service to resize the image, or find a good CDN that will do it for us. |
"Good, free, pick one." I could run a service on my home server, but then my internet goes out every so often, and I'm moving house soon. I don't imagine anyone here's looking to pay, either. |
Netlify lets you do all of this in about 4 clicks, it's also free. The resizing is taken care of by gatsby so you don't have to worry about a cdn or any other CI tool for that. I've just tested it on my end and the 12Mb C folder is shrunk all the way down to 400kb with full quality 250x250 webp previews 👍 As for netlify, you just sign in with github, click on the repo and it will detect the netlify configuration in the repo and figure out how to build and deploy the website on its own, it's really convenient. The tradeoff here (since there's always one) is long compile times. Gatsby tries to generate around 800 different sized images along with a separate page for each folder while compiling so a proper build takes a solid 5-7 minutes on a slow netlify machine. |
This repo doesn't get updates too often, so I don't expect long build times to be an issue. I'd be more worried about how someone can test their changes locally. |
Netlify supports hugo too, right? Hugo's build times are measured in milliseconds, from my (admittedly limited) experience. |
I'll have instructions for all that in the From what I know, when you introduce tooling to Hugo for processing css and minifying assets and such, the build times are comparable to Gatsby's. I haven't looked into Hugo much, I just prefer Gatsby because React is fantastic 👌 |
I have a basic preview up on https://anime-girls-holding-programming-books.netlify.com it's not styled yet but it's got the basic functionality for now |
WOWOWOWOW!!! EXCITED!!! I am going to make one too!!!!! On it!!! |
You do well, but I think it would be better if combined with a simple html
The text was updated successfully, but these errors were encountered: