-
-
Notifications
You must be signed in to change notification settings - Fork 10
General feedback after teaching #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for this very helpful feedback @tiagosousagarcia (and I'm sorry that it has taken so long to respond). I'm working on addressing the points that you have raised, and will post updates in this thread. |
Some quick updates:
I have added several exercises (e.g. in #35). More to come.
Good catch! I have replaced "normalization" with "standardization" and added some explanatory text. I'll add more on this later.
I have added an exercise to make it clear that the participants are expected to tweak the augmentation parameters themselves.
It looks strange, but I think the current code is correct. We want to call the
Good catch, now fixed. |
Auto-generated via `{sandpaper}` Source : f7d0ad6 Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 19:36:06 +0000 Message : tidying. avoid reuse of variable name. ref #21.
Auto-generated via `{sandpaper}` Source : a82d0c4 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2025-05-21 19:36:57 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : f7d0ad6 Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 19:36:06 +0000 Message : tidying. avoid reuse of variable name. ref #21.
Auto-generated via `{sandpaper}` Source : 912f92b Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 19:38:27 +0000 Message : More generous timing. Ref #21
Auto-generated via `{sandpaper}` Source : 8cc57f6 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2025-05-21 19:39:20 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 912f92b Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 19:38:27 +0000 Message : More generous timing. Ref #21
This was fixed in #32, though I have kept an issue open (#31) because I think there is a better solution than the one implemented.
Good point, I think I'd just left the default times in the template. I have updated the sections to allow for more time (now mostly 40min teaching, 20min exercises).
I've been caught by this before! Fixed in f7d0ad6 |
Auto-generated via `{sandpaper}` Source : 5fa007b Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 20:09:46 +0000 Message : Add explanation for architecture. Ref #21.
Auto-generated via `{sandpaper}` Source : 408366b Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2025-05-21 20:10:50 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 5fa007b Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 20:09:46 +0000 Message : Add explanation for architecture. Ref #21.
Auto-generated via `{sandpaper}` Source : 8575443 Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 21:05:43 +0000 Message : Add guidance on wher models can be tweaked to improve or alter their performance. Ref #21.
Auto-generated via `{sandpaper}` Source : a6c8460 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2025-05-21 21:06:28 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 8575443 Branch : main Author : Tom Pollard <[email protected]> Time : 2025-05-21 21:05:43 +0000 Message : Add guidance on wher models can be tweaked to improve or alter their performance. Ref #21.
@tiagosousagarcia Thanks again for this feedback - extremely helpful! I think I have addressed most of your points. If you have an opportunity, please could you take a look at the updated materials and let me know if further work is needed? |
We've run a workshop with this lesson yesterday at Newcastle University, and I thought it would be a good idea to leave some feedback from our experiences.
First of all, many thanks for all your hard work in the lesson, it is a great resource and it proved very popular with learners. It goes without saying but what follows is meant to be helpful feedback, rather than harsh criticism. With that in mind, here are some of the things that I've noticed:
If that cell needs to be re-run for any reason, the resulting dataset will get more and more dimensions, which might not be picked up until much later in the lesson (in our case, during model training)
Finally, a couple of specific problems/questions with code:
ImageDataGenerator
have different values? I.e., having everything at zero will simply create duplicates of existing images, no?augmented_images = [val_generator[0][0][0] for i in range(batch_size)]
beaugmented_images = [val_generator[i][0][0] for i in range(batch_size)]
otherwise we plot 5 equal images.That's it! Hope this is useful, and thanks again for your great work!
The text was updated successfully, but these errors were encountered: