Skip to content

Commit daf5c1e

Browse files
author
Muhammad Naufal Andika Natsir Putra
committed
chore: fix breaking imagebuilder_test.go
1 parent 864a033 commit daf5c1e

File tree

1 file changed

+0
-38
lines changed

1 file changed

+0
-38
lines changed

api/turing/imagebuilder/imagebuilder_test.go

-38
Original file line numberDiff line numberDiff line change
@@ -637,44 +637,6 @@ func TestBuildPyFuncEnsemblerServiceImage(t *testing.T) {
637637
artifactServiceMock.On("ReadArtifact", mock.Anything, modelDependenciesURL).Return([]byte(testCondaEnvContent), nil)
638638
},
639639
},
640-
"failure: image tag not matched": {
641-
expectedImageBuildingError: "error building OCI image",
642-
projectName: projectName,
643-
modelName: modelName,
644-
modelID: modelVersion,
645-
versionID: runID,
646-
clusterController: func() cluster.Controller {
647-
ctlr := &clustermock.Controller{}
648-
// First time it's called
649-
ctlr.On(
650-
"GetJob",
651-
mock.Anything,
652-
mock.Anything,
653-
mock.Anything,
654-
).Return(
655-
nil,
656-
k8serrors.NewNotFound(
657-
schema.GroupResource{},
658-
fmt.Sprintf("service-builder-%s-%s-%d-%s", projectName, modelName, modelVersion, runID[:5]),
659-
),
660-
).Once()
661-
return ctlr
662-
},
663-
buildLabels: map[string]string{
664-
"gojek.io/team": "dsp",
665-
},
666-
imageBuildingConfig: imageBuildingConfig,
667-
ensemblerFolder: ensemblerFolder,
668-
imageTag: "3.8.*",
669-
artifactServiceMock: func(artifactServiceMock *mocks.Service) {
670-
modelDependenciesURL := getHashedModelDependenciesUrl()
671-
artifactServiceMock.On("ParseURL", fmt.Sprintf("gs%s", testArtifactURISuffix)).Return(testArtifactGsutilURL, nil)
672-
artifactServiceMock.On("GetURLScheme").Return("gs")
673-
artifactServiceMock.On("GetURLScheme").Return("gs")
674-
artifactServiceMock.On("ReadArtifact", mock.Anything, fmt.Sprintf("gs%s", testCondaEnvUrlSuffix)).Return([]byte(testCondaEnvContent), nil)
675-
artifactServiceMock.On("ReadArtifact", mock.Anything, modelDependenciesURL).Return([]byte(testCondaEnvContent), nil)
676-
},
677-
},
678640
}
679641

680642
for name, tt := range tests {

0 commit comments

Comments
 (0)