Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not normalize based on highest match #431

Closed
korikuzma opened this issue Feb 5, 2025 · 1 comment · Fixed by #433
Closed

Do not normalize based on highest match #431

korikuzma opened this issue Feb 5, 2025 · 1 comment · Fixed by #433
Assignees
@korikuzma
Labels
enhancement New feature or request priority:high High priority

Comments

@korikuzma
Copy link
Member

Based on conversation with @ahwagner, if a source provides an identifier we should use this as the query rather than finding the highest match normalized result.
@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Feb 5, 2025
@korikuzma korikuzma self-assigned this Feb 5, 2025
@korikuzma korikuzma mentioned this issue Feb 7, 2025
Merged
@korikuzma korikuzma linked a pull request Mar 4, 2025 that will close this issue
feat!: use system identifiers from source for normalization #433
Merged
korikuzma added a commit that referenced this issue Mar 4, 2025
@korikuzma
feat!: use system identifiers from source for normalization (#433)
18b8124 
close #431 

* Rather than returning the highest match for a list of queries, use
system identifiers for source
* Input is now a single query, rather than a list
@github-actions github-actions bot closed this as completed Mar 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Closed by #433.

korikuzma added a commit that referenced this issue Mar 9, 2025
@korikuzma
feat!: use system identifiers from source for normalization (#433)
d510f55 
close #431 

* Rather than returning the highest match for a list of queries, use
system identifiers for source
* Input is now a single query, rather than a list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: use system identifiers from source for normalization cancervariants/metakb
1 participant
@korikuzma