Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change strength representation #419

Closed
korikuzma opened this issue Jan 21, 2025 · 1 comment · Fixed by #424
Closed

Change strength representation #419

korikuzma opened this issue Jan 21, 2025 · 1 comment · Fixed by #424
Assignees
@korikuzma
Labels
enhancement New feature or request priority:medium Medium priority

Comments

@korikuzma
Copy link
Member

korikuzma commented Jan 21, 2025 •
edited
Loading

Currently, strength is represented as:

{
            "code": "e000009",
            "label": "preclinical evidence",
            "system": "https://go.osu.edu/evidence-codes",
        }

But should be changed to:

{
            "primaryCode": "e000009",
            "label": "preclinical evidence",
            "mappings": [
                {
                    "coding": {
                        "id": "vicc:e000009",
                        "system": "https://go.osu.edu/evidence-codes",
                        "code": "e000009",
                    },
                    "relation": "exactMatch",
                },
                {
                    "coding": {
                        "id": "civic.evidence_level:D",
                        "system": "https://civic.readthedocs.io/en/latest/model/evidence/level.html",
                        "code": "D",
                    },
                    "relation": "exactMatch",
                },
                {
                    "coding": {
                        "id": "moa.assertion_level:preclinical_evidence",
                        "system": "https://moalmanac.org/about",
                        "code": "Preclinical evidence",
                    },
                    "relation": "exactMatch",
                },
            ],
        }
@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Jan 21, 2025
@korikuzma korikuzma self-assigned this Jan 21, 2025
korikuzma added a commit that referenced this issue Jan 21, 2025
@korikuzma
revert strength (save for #419)
14a8cf5
@korikuzma korikuzma mentioned this issue Jan 27, 2025
Merged
@korikuzma korikuzma linked a pull request Jan 27, 2025 that will close this issue
feat!: change strength representation #424
Merged
korikuzma added a commit that referenced this issue Feb 14, 2025
@korikuzma
feat!: change strength representation (#424)
277094a 
close #419 

* Change strength representation to align with GKS
  * `code `--> `primaryCode`
  * Remove `system` and add `mappings`
@github-actions GitHub Actions
Copy link

Closed by #424.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: change strength representation cancervariants/metakb
1 participant
@korikuzma