-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViccNormalizerDataExtension
should be moved to mappings
#418
Comments
Need to figure out if we change relation to exact match or use what's in the normalizers |
I realize we also need to retain if it was the merged concept ID (from priority source). Thinking of updating the extension to be: "extensions": [
{
"name": "from_vicc_normalizer",
"value": {"is_merged_identifier": True}
}
] or "extensions": [
{
"name": "vicc_normalizer_merged_id",
"value": True
}
] Where @jsstevenson @katiestahl thoughts? Open to alternatives. Update: Not sure about |
close #418 * Remove VICC normalizer data extension and move this information to `mappings` * A concept mapping in `mappings` will have an extension with name `vicc_normalizer_priority` if this concept mapping came from the VICC normalizers. When the value is `True`, this means that the concept mapping is the priority code / label for the merged record. When the value is `False` this means that the concept mapping comes from the merged record's mappings.
Closed by #425. |
Currently, we have the a
ViccNormalizerDataExtension
inMappableConcept.extensions
. ForDisease
conceptTypes, this looks like:However, we should actually be storing these as
ConceptMappings
inmappings
:I might need to check with @ahwagner on
relation
values.The text was updated successfully, but these errors were encountered: