Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database layer refactor #357

Open
jsstevenson opened this issue Jun 12, 2024 · 2 comments
Open

Database layer refactor #357

jsstevenson opened this issue Jun 12, 2024 · 2 comments
Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@jsstevenson
Copy link
Member

A few varied but related issues to wade through

  • use singleton constructor for graph
  • make metakb.database.Graph injectable in places like the QueryHandler
  • feasibility of adhering to yield/close pattern for all cases where graph is used
  • separate the graph access class and more specific data loading methods (i.e. those used by transformers)
  • think about where we want transactional queries vs atomic queries

Generally, we want to focus on clean access to the graph, and to be very careful about any case where resources are manually managed and not automatically deconstructed. It's a little sloppy but improved in #356, but we can make it cleaner and more consistent with a refactor

@jsstevenson jsstevenson added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Jun 12, 2024
Copy link

This issue is stale because it has been open 135 days with no activity. This issue will be closed if no further activity occurs in 14 days.

@github-actions github-actions bot added the stale label Feb 19, 2025
Copy link

github-actions bot commented Mar 5, 2025

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2025
@jsstevenson jsstevenson added priority:low Low priority and removed priority:medium Medium priority stale closed-by-stale labels Mar 5, 2025
@korikuzma korikuzma reopened this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

No branches or pull requests

2 participants