Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide source object ID in search endpoints #269

Closed
korikuzma opened this issue Dec 21, 2023 · 4 comments
Closed

Add ability to provide source object ID in search endpoints #269

korikuzma opened this issue Dec 21, 2023 · 4 comments
Labels
enhancement New feature or request gk-pilot Issues or pull requests related to gk pilot priority:low Low priority stale

Comments

@korikuzma
Copy link
Member

Currently, we run query parameters (variation, disease, therapy, gene) through our normalizers. I think we should allow for source identifiers (such as civic.vid:12) to be searched. I'm not sure if we would want to create a separate endpoint for this or add to existing enpoints

@korikuzma korikuzma added enhancement New feature or request priority:low Low priority gk-pilot Issues or pull requests related to gk pilot labels Dec 21, 2023
Copy link

This issue is stale because it has been open 45 days with no activity. Please make a comment for triaging or closing the issue.

@github-actions github-actions bot added the stale label May 11, 2024
@korikuzma korikuzma removed the stale label May 13, 2024
@jsstevenson
Copy link
Member

Yeah, this is interesting. Since we know the source ID patterns in advance, maybe we could do a quick regex on each term as it comes in to determine whether it gets sent to a normalizer or incorporated directly into a query (optionally disable-able?).

Copy link

This issue is stale because it has been open 180 days with no activity. This issue will be closed if no further activity occurs in 14 days.

@github-actions github-actions bot added the stale label Feb 19, 2025
@korikuzma
Copy link
Member Author

We'll probably need something like this at some point, but for now I'm going to close. If it is needed, we can re-open or create a new issue that uses the issue templates.

@korikuzma korikuzma closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gk-pilot Issues or pull requests related to gk pilot priority:low Low priority stale
Projects
None yet
Development

No branches or pull requests

2 participants