Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all Entity properties to snake case and enforce JSON camelCase convention #88

Open
mfekadu opened this issue Feb 29, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mfekadu
Copy link
Member

mfekadu commented Feb 29, 2020

That's the convention for Python

Extra Details

  • will need to also change all occurrences of the properties
@mfekadu mfekadu added the bug Something isn't working label Feb 29, 2020
@mfekadu
Copy link
Member Author

mfekadu commented Mar 1, 2020

Alternative

@mfekadu
Copy link
Member Author

mfekadu commented Mar 2, 2020

Let’s definitely use Marshmallow

As a result, we will enforce JSON naming conventions for interacting with the REST API.

The schema of each endpoint will need to be communicated with to the corresponding scraper

calpoly-csai/csai-scraping#11

The scraper will need to update it’s set of column names for each scraper.

@mfekadu mfekadu changed the title Convert all Entity properties to snake case Convert all Entity properties to snake case and encore JSON camelCase convention Mar 2, 2020
@mfekadu mfekadu changed the title Convert all Entity properties to snake case and encore JSON camelCase convention Convert all Entity properties to snake case and enforce JSON camelCase convention Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants