Skip to content

Commit 0cb2234

Browse files
authored
fix: NSInvalidArgumentException when passing accessibilityIncrements (#682)
This fixes a NSInvalidArgumentException which causes a full app crash when `<Slider accessibilityIncrements={['anything non-empty array']} />` is rendered, by initializing an NSMutableArray instead of an NSArray, as it called with `addObject:` if `accessibilityIncrements` is non-empty.
1 parent f458a1c commit 0cb2234

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

package/ios/RNCSliderComponentView.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
218218
slider.accessibilityUnits = convertedAccessibilityUnits;
219219
}
220220
if (oldScreenProps.accessibilityIncrements != newScreenProps.accessibilityIncrements) {
221-
id accessibilityIncrements = [NSArray new];
221+
id accessibilityIncrements = [NSMutableArray new];
222222
for (auto str : newScreenProps.accessibilityIncrements) {
223223
[accessibilityIncrements addObject:[NSString stringWithUTF8String:str.c_str()]];
224224
}

0 commit comments

Comments
 (0)