Skip to content

Commit 13c1c19

Browse files
authored
chore: use the macOS 14 with M1 processor runner on workflows (#522)
### Summary We were using an older version of macOS (macOS 12). As of January 30th, 2024, GitHub announced the new M1 macOS runner. [Here's the link for the blog post](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) ### Test plan We need to make sure CI passes with the changes
1 parent 29d446b commit 13c1c19

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

.github/workflows/build-templates.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
os:
25-
- ubuntu
26-
- macos
25+
- ubuntu-latest
26+
- macos-14 # macos latest defaults to macos 12 at the moment.
2727
type:
2828
- module-legacy
2929
- module-mixed
@@ -37,9 +37,9 @@ jobs:
3737
- kotlin-objc
3838
- kotlin-swift
3939
exclude:
40-
- os: macos
40+
- os: macos-14
4141
language: kotlin-objc
42-
- os: macos
42+
- os: macos-14
4343
language: kotlin-swift
4444
- type: module-new
4545
language: java-swift
@@ -58,33 +58,33 @@ jobs:
5858
- type: view-mixed
5959
language: kotlin-swift
6060
include:
61-
- os: ubuntu
61+
- os: ubuntu-latest
6262
type: library
6363
language: js
64-
- os: ubuntu
64+
- os: ubuntu-latest
6565
type: module-legacy
6666
language: cpp
67-
- os: ubuntu
67+
- os: ubuntu-latest
6868
type: module-mixed
6969
language: cpp
70-
- os: ubuntu
70+
- os: ubuntu-latest
7171
type: module-new
7272
language: cpp
73-
- os: macos
73+
- os: macos-14
7474
type: module-legacy
7575
language: cpp
76-
- os: macos
76+
- os: macos-14
7777
type: module-mixed
7878
language: cpp
79-
- os: macos
79+
- os: macos-14
8080
type: module-new
8181
language: cpp
8282

8383
concurrency:
8484
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-${{ matrix.type }}-${{ matrix.language }}
8585
cancel-in-progress: true
8686

87-
runs-on: ${{ matrix.os }}-latest
87+
runs-on: ${{ matrix.os }}
8888

8989
steps:
9090
- name: Checkout
@@ -138,14 +138,14 @@ jobs:
138138
working-directory: ${{ env.work_dir }}
139139
run: |
140140
# Build Android for only some matrices to skip redundant builds
141-
if [[ ${{ matrix.os }} == ubuntu ]]; then
141+
if [[ ${{ matrix.os }} == ubuntu-latest ]]; then
142142
if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
143143
echo "android_build=1" >> $GITHUB_ENV
144144
fi
145145
fi
146146
147147
# Build iOS for only some matrices to skip redundant builds
148-
if [[ ${{ matrix.os }} == macos ]]; then
148+
if [[ ${{ matrix.os }} == macos-14 ]]; then
149149
if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
150150
echo "ios_build=1" >> $GITHUB_ENV
151151
fi

packages/create-react-native-library/templates/common/$.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jobs:
105105
yarn turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}"
106106
107107
build-ios:
108-
runs-on: macos-latest
108+
runs-on: macos-14
109109
env:
110110
TURBO_CACHE_DIR: .turbo/ios
111111
steps:

0 commit comments

Comments
 (0)